From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7850F3A6B85 for ; Thu, 16 Jul 2026 20:52:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784235164; cv=none; b=AArPOxmPHK2ir4CNxx70O7SunrsIlm4g/CnJcJbWj4BSFNhDAYJICO1+Xa5K6EPhpDcEm2X0/X2vle2wEsMCy2hXR3ZlPiN5EDhxbg7/ui3Vh4oh4mYirzhBnIpATB2bvUC1hP4GvI0ms5KUgBNdLacvrFe7XUT4M+ZMMQRILwk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784235164; c=relaxed/simple; bh=9dfbfqdoXKn10lcawgomrLNnCs1SPKM9oBMb8rYI5ws=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=fkbjUTtbrNBRoperRDgEXv3pfjM4HfYkclMpMBiAy6cIr92AAeGrbO7IRT+rS4BYd3YSUC+aOrK+DoYAu3aKBulY8UaF5P2QWeCUsdrpmY/gRqvl20c+do2e8tUWm1Cbqqm1is5UXDrZ9PSRJW2b6/Wq1mkYdASyxbnpJOgYDsA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=AuSPwI3E; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="AuSPwI3E" Received: by smtp.kernel.org (Postfix) with ESMTPSA id EE7931F000E9; Thu, 16 Jul 2026 20:52:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1784235163; bh=9dfbfqdoXKn10lcawgomrLNnCs1SPKM9oBMb8rYI5ws=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=AuSPwI3EW3NNq/PxRwu0HFJKNU7dvSgdRJikh94kb7n5Ivgp7F3JVC7AqpM1nVNIl z/TeOymVafponmg0NujiWjLY/aCzgrBMwcdujOuAjlWODHFplHlty3PLByjTvsDfAS 2XofCdyzNuui3SzYUJQRkyVktVqB2TazhDbcTRI24HQqAOX0XKdryNOqp6XD8aELc0 PVQrnOuG/GZDSkUy0U/JYBBRb6WKD6HrcmWIgMfHQhl4iY5s9XanKvfJE4L/EwVDs8 W0rI08nDkN3906ExAVVAWMMCCQy1wEI2WZClbezHrdWSXjRDjSrmkX7/xVE92QKTp8 ZySLVVzChGB/g== Date: Thu, 16 Jul 2026 14:52:41 -0600 From: Keith Busch To: Jun Zeng Cc: axboe@kernel.dk, hch@lst.de, sagi@grimberg.me, linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, andriy.shevchenko@intel.com, gang.cao@intel.com, jun.i.jin@intel.com, yong.hu@intel.com, Liang Fang Subject: Re: [PATCH v1 1/1] nvme-pci: adaptive interrupt coalescing Message-ID: References: <20260715075703.15578-1-jun1.zeng@intel.com> <20260715075703.15578-2-jun1.zeng@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260715075703.15578-2-jun1.zeng@intel.com> On Wed, Jul 15, 2026 at 03:57:03PM +0800, Jun Zeng wrote: > Add adaptive interrupt coalescing to improve IOPS for high-throughput > workloads. Monitor IO pressure periodically and enable/disable coalescing > automatically based on IOPS, queue depth, and inflight IO thresholds. > This feature is enabled by default, can be controlled through debugfs > variable during runtime. Can't you do all this from user space? You'd maybe need the blk-mq debugfs to get access to the individual hctx dispatch numbers, but maybe that's okay? The atomic_long_inc where you placed it is especially harmful to polled queues.