All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Theodore Tso" <tytso@mit.edu>
To: Jonathan Corbet <corbet@lwn.net>
Cc: Sasha Levin <sashal@kernel.org>, ksummit@lists.linux.dev
Subject: Re: [MAINTAINERS SUMMIT] Other LLM-related topics - tags, newcomers, etc
Date: Thu, 16 Jul 2026 17:23:35 -0400	[thread overview]
Message-ID: <allGeaXQ6DFv1M14@mit.edu> (raw)
In-Reply-To: <87y0fa7pdm.fsf@trenco.lwn.net>

On Thu, Jul 16, 2026 at 12:36:53PM -0500, Jonathan Corbet wrote:
> The related discussions have featured a number of maintainers talking
> about how much time Sashiko has saved them.  I believe them.  How long
> will it take until nobody does that level of patch review anymore?  What
> will we do when the current round of corporate generosity ends and that
> tool goes away?  Maybe I'm worrying too much, but this does seem, to me,
> like a possibility we should keep in mind.

Sashiko finds issues that human reviewers wouldn't necessarily notice.
Before Sashiko, at least for ext4, I'd find those sorts of issues by
running 24 VM hours worth of fstests, and rely on that testing to find
problems that I might miss when doing the initial patch review.  Could
I have found it by spending 3 times as much time looking at each
commit, and thinking deeply?  Sure.  But I don't have the time for
that, so I've *already* relied on Google contributing roughly two
dollars of VM time for each 24 hour regression test run.  Sashiko
might be a bit more expensive on a per-patch basis, but just as I
never viewed fstests as a replacement for human-level review, I don't
think Sashiko is complete substitute human review.

We still need experienced human reviewers to ask whether the fix is
being done in the right place, or whether the right solution is to
*remove* code as opposed to *adding* code, etc.  This is critical if
we want the code to be maintainable in the long-term.  I agree that if
reviewers stop doing this, we would be in a world of hurt --- but that
can happen if people were to start relying on kunit tests passing as a
substitute for code review.

						- Ted

      parent reply	other threads:[~2026-07-16 21:23 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-16 15:09 [MAINTAINERS SUMMIT] Other LLM-related topics - tags, newcomers, etc Jonathan Corbet
2026-07-16 15:28 ` Sasha Levin
2026-07-16 16:08   ` Mark Brown
2026-07-16 16:24     ` Sasha Levin
2026-07-16 20:38       ` Laurent Pinchart
2026-07-16 18:36   ` Jonathan Corbet
2026-07-16 19:53     ` Mauro Carvalho Chehab
2026-07-16 20:05     ` Bart Van Assche
2026-07-16 20:52       ` James Bottomley
2026-07-16 20:23     ` Liam R. Howlett
2026-07-16 21:23     ` Theodore Tso [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=allGeaXQ6DFv1M14@mit.edu \
    --to=tytso@mit.edu \
    --cc=corbet@lwn.net \
    --cc=ksummit@lists.linux.dev \
    --cc=sashal@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.