From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 56C69334C2E for ; Fri, 17 Jul 2026 03:42:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784259749; cv=none; b=gxRYkYaZzPj8ioLgZXeCQTCnmmtbV9d+/pVU1h7aryjDfV0vAo3ewzAxhjdV/lMuZw6+Tv6UDZrHhDwdag02Yyo8M6OlV9qZc4smI9vTZivAWCzD1yAjrCBSMONeMqbt74GmOQGmW8StTzF1IHB/uu0hA6uK6zeoIq1sS9/V6ko= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784259749; c=relaxed/simple; bh=PZLunVrkyHtC9wfdf+kbcQ5bdeFIPeDTlnp6w7k2OYc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=oF6dxJSr3KxjoLQifDR9EVP3kw9JX+Cbf1edS0TZxwWbXHVr0gT8Y4B9VqWokxDVSMaf8dNWUBx9zlLsiy9dIj/76Ow8HOd3IEfq8Ttfu61k/bhHEzz8NM2YAYDvL3mG8/deZxQnibdytTxgXH6Q27niNgR14UBjkkrthIbCatQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=bdJmPiFL; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=kZ3PJlxN; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="bdJmPiFL"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="kZ3PJlxN" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66H34So7680043 for ; Fri, 17 Jul 2026 03:42:26 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=l5saWHr3dnLJEHPhwGPzYl0K X1zNELXP1BiUWCkz+mA=; b=bdJmPiFLP6nRbBRlNw19xZ463qICNAeLUdMVQitv j86NJrmzrC89aWZXPVwFKkd6fvSSBE5OEbbFA3dDN3oU74Q4/Bb72Al/XP+axYYA uSz8y7LO6disXMPVxTouGQnsWacHrLS3XrLGXVYROkT/vpnalhN36KAI2SM2quwk y+e5YuHpkXJH0XPUFalLjOPzFmJwIFc/Eq7SHal9VLGdCe+364DBp67bfAf0vs8d e/w7fUYEVDoEHDffFN9cpyUGlvfpMgODPa5QRgDXqe2mBCgVXhw9P3PYdPUp06dq tRA5/cHQ55v5hDjA6p2UILUi5Tv5EI/9kC4Re1Rec67p8A== Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fetcf4huk-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 17 Jul 2026 03:42:26 +0000 (GMT) Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-38dc085b0a7so10303997a91.2 for ; Thu, 16 Jul 2026 20:42:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784259746; x=1784864546; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=l5saWHr3dnLJEHPhwGPzYl0KX1zNELXP1BiUWCkz+mA=; b=kZ3PJlxN1micX76bAvnaIOyf/69GCmwpcTqXeMjN4Ua6/GnB8T3w10OzD+6fQFxLoc 5M3iB8GT7MUCMK/EEpmXzIACY0UElKr2GdDXf4GUzOKGWlnft5IFSHSCjmIzBgXHrE2j uvbbt/Ci7MYJrDx2UTYGF0vLixmc0F+nhbqfdS5v+Cs1QbRoYJig8cOdB4cNrdBG4mq8 2fgxzNKHXtlbR0bq+FaaUgZdgN+sSeSfasTpFDN+8fkP/UJPSdiy7p3ABEdQjeIbDsxY Kw8tnz++GQ5Inm3kCZEuD0/SEiGlgrrBT0I/xjNV7AL6ifmvykGemgIN3TUN6PG/eMIa 6lAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784259746; x=1784864546; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=l5saWHr3dnLJEHPhwGPzYl0KX1zNELXP1BiUWCkz+mA=; b=pgoK+VCOWRndumrEYGAaYEaU5knQMrXxKkTHw54cjKF/6w+GXbI3rpU8dQgs8D966Q FMWUFja1Bx6EHZ81800y9qPtW9BSBoqRbjmBrHHwA4+vL/IZxeUxJ6T2VLmwwuPO7hRq 5qqvdvjcWZ7PvsvRYlklK82lpJ4ZSPq6p3/kvpUJXRchK30P86jswHojd8s2S5Hb16Dt vqugeGhAsk+XcGXTNP6TfHGDAXqrNlNgXvsEWJmVayPdiBRM2m0JViozZiqz4SBD/s/f KqBHojWcC7maj8pHHtbI8bbh61OezMOklSofg+MhbN3iK1pvLQdjs02V1byWWWABz8EC nCsg== X-Forwarded-Encrypted: i=1; AHgh+RrMm+vZAccptX+52UorfpLks6++wjFCON7rn2AwBWfhftHLbGUDFYUzihw/PkvciTqtQevEw/h8vn0=@vger.kernel.org X-Gm-Message-State: AOJu0YxK8r5dBszpiVrBTf+XJr+GnIMK3Vj7qV++bPyWl/8GmFvAhA/9 iMlqRwM9NYUdHT1dWB0t6xFCWgMUCHGuolCkbM6sK8l3WrItnREhlaYeEGeTApLsniD0/AfHOZ7 7HKxsnWdOrP6SDznpZJMIUBjEhXG7TJPkh5jVaH1aV7iD7K0YK/pVYQCL/Oy6kV0= X-Gm-Gg: AfdE7cmRV9+Cj8pQnQqPbKB15ARFlOsVDhzfSjn4Futve8PlRj9LylaI9O/GfXM1f1h Me1XL1o/AhcGDryAV69Tubg9DeENNSxe3MivG/+HuB8AfCkOQUNHQDGFQYgDu9e4Ybrp/oDV4zl lK6f2baPtkSuP1hRUoagIPwrC9i3bpAUlthRPqpyIdXBBtj7T1UU0HeiWwo9Pg2/doikPCI9D/d ziqaraECm7Q5kRWemSNS/PgU9rDdyBsl1pWCImr1H9pGOfs0iNuan63n7I0kwLvYRLMOXoHz0K9 di0LaZFOhJFbuvBbc3oM3SUZ19vaXbS1q0XMhGIdhzSpIJvj558yEhWtlu2GMnyrg+fVuF/7/ED EEDaL+XZdrPkOnnjD56dkoHEheNA/a/dBtJ9FIjXMCpiRZjUWWQ== X-Received: by 2002:a17:90b:528d:b0:384:d509:7274 with SMTP id 98e67ed59e1d1-38e4b448dffmr769078a91.15.1784259745798; Thu, 16 Jul 2026 20:42:25 -0700 (PDT) X-Received: by 2002:a17:90b:528d:b0:384:d509:7274 with SMTP id 98e67ed59e1d1-38e4b448dffmr769059a91.15.1784259745345; Thu, 16 Jul 2026 20:42:25 -0700 (PDT) Received: from hu-petche-lv.qualcomm.com (Global_NAT1.qualcomm.com. [129.46.96.20]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3142a1de301sm1702185eec.24.2026.07.16.20.42.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jul 2026 20:42:24 -0700 (PDT) Date: Thu, 16 Jul 2026 20:42:22 -0700 From: Peter Chen To: Thinh Nguyen Cc: Krishna Kurapati , Krzysztof Kozlowski , Dmitry Baryshkov , Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Wesley Cheng , "linux-arm-msm@vger.kernel.org" , "linux-usb@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v4 1/2] dt-bindings: qcom,snps-dwc3: Add property indicating presence of eUSB2 phy Message-ID: References: Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Proofpoint-ORIG-GUID: w5g6uZubxh_YjPbR9L4yWud3URcep59f X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzE3MDAzMSBTYWx0ZWRfX9vAahk1Q7uWS gONCxt8COcJS6A++2PoEgVJ86oS4CTLcWfbaujfYpXzBXesOxKFKc24YFBF1CKu/Oq223fjTIjV ClQcHVQLypRBdeYW83TCK+wzdTUeuaPxDg9FfSvibK9HY1ubjXPYxjpetHwzUV1XRmnBS0SDJFE h2fUPXp4QUE49S3wmY616IKGCzoYwzRKhg7DSu+gQCCae6tV8IUu1smxB2pQiQqXkjWGVHTWNaB cbYNa39FG7fYd085nsHrmf8Hto0G4jaeow2O7XKU28zhy8hXQWqAc0CTDIlElBJ6HEj/UTlY5U5 y68nLwTXyd7qXQQBoubwwLvfExo0nJd4iAwOuCe3V7laVohG4OYNxTpOY7KZuoZ4pPy5mVbeiwT RY7btHlUrw6gEgCCN2eVbmfccQ3IYHCv2TgTmB+YyGsu/HNihcZZiZi7nBm35TInj0fm1nRd01K nDBx621IIEs/zMqWUFA== X-Authority-Analysis: v=2.4 cv=f8R4wuyM c=1 sm=1 tr=0 ts=6a59a4a2 cx=c_pps a=RP+M6JBNLl+fLTcSJhASfg==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17 a=kj9zAlcOel0A:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=zDMlSImzIToMmpLGiZwA:9 a=CjuIK1q_8ugA:10 a=iS9zxrgQBfv6-_F4QbHw:22 X-Proofpoint-GUID: w5g6uZubxh_YjPbR9L4yWud3URcep59f X-Proofpoint-Spam-Info: AW1haW4tMjYwNzE3MDAzMSBTYWx0ZWRfX/tn5vpBpGhQn fl+kWvT9lr9i6PdHibVekcTAJJhpMIqYCscQ3YZb5GwTM0j+tRFdAkBNWvCcrDoq0tn1HTZtQwS clFZ3YebXsH09PIKz1gzpE8DEkXZ0Ts= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-17_01,2026-07-15_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 clxscore=1015 impostorscore=0 priorityscore=1501 bulkscore=0 phishscore=0 suspectscore=0 lowpriorityscore=0 malwarescore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607170031 On 26-07-17 01:56:59, Thinh Nguyen wrote: > On Thu, Jul 16, 2026, Peter Chen wrote: > > On 26-07-17 00:06:37, Thinh Nguyen wrote: > > > > > > > > I have seen fewer platforms use "phy_type" at dts for arm64, dwc3 > > > > core uses it only for special cases and the code was added for > > > > ten years ago. For the default situation, we may not need to > > > > change DWC3_GUSB2PHYCFG_EUSB2OPMODE value for UTMI+, Thinh, is it > > > > correct? > > > > > > > > > > The GUSB2PHYCFG.eUSB2OPMODE is only relevant for host mode and mainly > > > for electrical compliance. Usually by default, the CoreConsultant > > > setting should have this set correctly. So not explicitly setting it > > > should be functionally fine (IIRC). > > > > > > That said, this is separate from the GUSB2PHYCFG.PHYIF, which the core > > > uses dwc->hsphy_mode to indicate whether the UTMI interface is 8-bit or > > > 16-bit. > > > > > > > Why only rockchip uses this "phy_type" property, why other SoC vendors > > no this requirement for UTMI width setting? > > > > Not just rockchip, some tegra and hikey also use it. Some old qcom dts > files also have it for ulpi. Tegra and old qcom platforms use chipidea, hikey uses dwc3. > > It is typically set when the coreConsultant default differs from what > the platform needs, so the driver can override it with the correct > setting. > > My point is that changing "phy_type" definition is more involved than it > looks. I'm open to alternatives. > I know your concern that in case the eUSB2 PHY SoC wants to change UTMI width, it can't do that. Are there controller register know it connects eUSB2 PHY? For the place to put "eusb2" for phy type, I still think enum usb_phy_interface at: include/linux/usb/phy.h is the most suitable place, would you have any alternatives? Another solution is using generic PHY API phy_get_mode, set fixed "eusb2" mode at eUSB2 PHY driver, but it depends on PHY driver doesn't have different settings for device and host mode. Other solution is compare the generic PHY compatible string at dwc3 qcom glue layer, it depends on eUSB2 PHY compatible string always contains "eusb2-phy" I prefer the solution that extend enum usb_phy_interface for eUSB2 PHY, it uses existed kernel structure and device tree binding. -- Thanks, Peter Chen