From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C14B2301719 for ; Fri, 17 Jul 2026 08:42:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784277778; cv=none; b=YrJuam6w85BrbJbTqV6zkv5a71VoXteXYIJ0iO6s+12QGJDvfAxD5kMiaiQZcLlEQtVNfGzWPqnKzS9AO2GDv78SmUhUPbyiDmuvkkiHl5SYNzgk5estIEkiyHurRd1GlFbWn41fQJUfwkM1cu3FTc2NXXgki66vIg9JoHp0x20= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784277778; c=relaxed/simple; bh=6YTjBeFfgAgGfa9z1PoDNw5JjKgEAE4ApPqrEJSgqSI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=leFVWN6/qK15rxivDg7ZhcWuPNVJvZYdLGL91VD/H4t8XUtgvx2bF2DsKvoHui7Ni/5mTiC3P0cpeYSirDrfwpVu9g3HI0/17LE2XsKaRbCoi+DqNYTfGa1IaiIQVVSgOp/mV0OuU6oC3OQLKUJ2H93lnstovuemZglHHYpSQUA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=oVA5EmBe; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="oVA5EmBe" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D0EDF1F000E9; Fri, 17 Jul 2026 08:42:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1784277777; bh=baJDKQtOmn830PMPPEShxsN1hszR+BkQ8H4HqPNyHQY=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=oVA5EmBez2eOE5I+iqNMT6alzpkoWOOsxG0glE9kD4C1uA+jZ/7wgef8XLCJQ5MtR /ZShKzQgNlmlZ6OOHrav6ZfIqHeGMcd7hKNPxFyF/tUkJYD6sESG3pX3BCVVp1Zv+y 6Dhc0mu+PD6u9Ef3xMOqLEhWorCtdeIuhvwtdiMqZwuWDln3uZG5cl0c/MJLE2DXrY y5QrSmdcDe591MSG2wfI5kxMAo575AP4lmQdO+KkHQeAJxUpW+Mz5VkZHDoUWbCb3B lgPVrq+9yJaP28gCs7Us989Jz1Ek4cTqETd0mUFfesslcJduTl3lryTj+4HPCBrD27 O45bml1yJpM7w== Date: Fri, 17 Jul 2026 09:42:41 +0100 From: "Lorenzo Stoakes (ARM)" To: Hongfu Li Cc: akpm@linux-foundation.org, david@kernel.org, liam@infradead.org, vbabka@kernel.org, rppt@kernel.org, surenb@google.com, mhocko@suse.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Hongfu Li Subject: Re: [PATCH] mm/folio-compat: Drop superfluous return statements in void compat wrappers Message-ID: References: <20260717072054.74260-1-hongfu.li@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260717072054.74260-1-hongfu.li@linux.dev> On Fri, Jul 17, 2026 at 03:20:54PM +0800, Hongfu Li wrote: > From: Hongfu Li > > unlock_page(), end_page_writeback() and wait_on_page_writeback() > are void wrappers forwarding to folio-based functions which also > return void. Explicit return statements here are syntactically valid > but unnecessary, and inconsistent with other nearby compat helpers > such as mark_page_accessed() and set_page_writeback(). > > Drop all these superfluous return keywords. > > Signed-off-by: Hongfu Li LGTM so: Reviewed-by: Lorenzo Stoakes (ARM) I would ask that you maybe slow down on the flow of patches lately :) review is pretty overwhelmed atm. > --- > mm/folio-compat.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/mm/folio-compat.c b/mm/folio-compat.c > index a02179a0bded..8eb3e7fe4c91 100644 > --- a/mm/folio-compat.c > +++ b/mm/folio-compat.c > @@ -13,19 +13,19 @@ > > void unlock_page(struct page *page) > { > - return folio_unlock(page_folio(page)); > + folio_unlock(page_folio(page)); > } > EXPORT_SYMBOL(unlock_page); > > void end_page_writeback(struct page *page) > { > - return folio_end_writeback(page_folio(page)); > + folio_end_writeback(page_folio(page)); > } > EXPORT_SYMBOL(end_page_writeback); > > void wait_on_page_writeback(struct page *page) > { > - return folio_wait_writeback(page_folio(page)); > + folio_wait_writeback(page_folio(page)); > } > EXPORT_SYMBOL_GPL(wait_on_page_writeback); > > -- > 2.54.0 > Thanks, Lorenzo