From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: "Uwe Kleine-König (The Capable Hub)" <u.kleine-koenig@baylibre.com>
Cc: Johan Hovold <johan@kernel.org>,
linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] MIPS: ip22-gio: Drop #include of <linux/mod_devicetable.h>
Date: Fri, 17 Jul 2026 13:01:27 +0200 [thread overview]
Message-ID: <aloLh6Ja6aYTiLD1@alpha.franken.de> (raw)
In-Reply-To: <d90003bf53495591a15a5854fa2845fdee8f8d11.1783671791.git.ukleinek@kernel.org>
On Fri, Jul 10, 2026 at 10:24:12AM +0200, Uwe Kleine-König (The Capable Hub) wrote:
> That header doesn't use any device id provided by
> <linux/mod_devicetable.h>. Also the users of <asm/gio_device.h> (i.e.
> arch/mips/sgi-ip22/ip22-gio.c and drivers/video/console/newport_con.c)
> don't use any of them and they compile fine in a mips allmodconfig.
>
> So drop the unused include that only yields unnecessary recompilations
> when a device id struct changes.
>
> Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>
> ---
> arch/mips/include/asm/gio_device.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/mips/include/asm/gio_device.h b/arch/mips/include/asm/gio_device.h
> index f9c102f038d6..6e9d2897347d 100644
> --- a/arch/mips/include/asm/gio_device.h
> +++ b/arch/mips/include/asm/gio_device.h
> @@ -1,6 +1,5 @@
> /* SPDX-License-Identifier: GPL-2.0 */
> #include <linux/device.h>
> -#include <linux/mod_devicetable.h>
>
> struct gio_device_id {
> __u8 id;
>
> base-commit: 34cf6dafc47441dfb6b356a095b89c3585a93714
> --
> 2.55.0.11.g153666a7d9bb
applied to mips-next
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
prev parent reply other threads:[~2026-07-17 11:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-10 8:24 [PATCH v1] MIPS: ip22-gio: Drop #include of <linux/mod_devicetable.h> Uwe Kleine-König (The Capable Hub)
2026-07-17 11:01 ` Thomas Bogendoerfer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aloLh6Ja6aYTiLD1@alpha.franken.de \
--to=tsbogend@alpha.franken.de \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.