From: Peter Antoine <peter.antoine@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [I-G-T 3/3] igt/gem_mocs_settings: Reduce the amount of cascading failures
Date: Mon, 1 Aug 2016 10:33:17 +0100 (BST) [thread overview]
Message-ID: <alpine.DEB.2.10.1608011030040.2912@peterant-linux2> (raw)
In-Reply-To: <20160801090217.GC17227@nuc-i3427.alporthouse.com>
On Mon, 1 Aug 2016, Chris Wilson wrote:
> On Fri, Jul 29, 2016 at 10:34:36AM +0100, Peter Antoine wrote:
>> If one of the previous tests fails then the following tests fail.
>> This patch means that the following tests do not fail when the previous
>> test fails (for some cases).
>
> The problem is just gem_mocs_settings hasn't split its tests up into
> subtests.
Chris,
Can you expand? The tests are at the minimal size for sensible results (I
think). The problem is opening the driver for master when the test fails
then the following tests will fail as master is not closed.
Is there a mechanism in the igt framework for doing this close on
failure/skip?
If I move the master open code in the fixtures will this get called on all
exit cases?
Peter.
> -Chris
>
>
--
Peter Antoine (Android Graphics Driver Software Engineer)
---------------------------------------------------------------------
Intel Corporation (UK) Limited
Registered No. 1134945 (England)
Registered Office: Pipers Way, Swindon SN3 1RJ
VAT No: 860 2173 47
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-08-01 9:33 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-29 9:34 [I-G-T 0/3] igt/gem_mocs_settings: Update MOCS tests Peter Antoine
2016-07-29 9:34 ` [I-G-T 1/3] igt/gem_mocs_settings: Remove direct register tests Peter Antoine
2016-07-29 9:34 ` [I-G-T 2/3] igt/gem_mocs_settings: adding RC6 testings Peter Antoine
2016-07-29 9:50 ` Antoine, Peter
2016-07-29 9:34 ` [I-G-T 2/3] igt/gem_mocs_settings: adding RC6 tests Peter Antoine
2016-08-01 9:04 ` Chris Wilson
2016-08-01 9:16 ` Peter Antoine
2016-08-01 10:03 ` Peter Antoine
2016-08-01 10:11 ` Chris Wilson
2016-08-01 10:43 ` Peter Antoine
2016-07-29 9:34 ` [I-G-T 3/3] igt/gem_mocs_settings: Reduce the amount of cascading failures Peter Antoine
2016-08-01 9:02 ` Chris Wilson
2016-08-01 9:33 ` Peter Antoine [this message]
2016-08-02 14:37 ` Daniel Vetter
2016-08-02 14:47 ` Antoine, Peter
2016-08-03 7:36 ` Daniel Vetter
2016-08-03 8:49 ` Antoine, Peter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.10.1608011030040.2912@peterant-linux2 \
--to=peter.antoine@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.