From: Julia Lawall <julia.lawall@lip6.fr>
To: Anchal Jain <anchalj109@gmail.com>
Cc: gregkh@linuxfoundation.org, outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH 1/2] staging: rtl8188eu: core: rtw_ap: remove boolean comparison
Date: Fri, 30 Sep 2016 19:32:02 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.10.1609301931330.3399@hadrien> (raw)
In-Reply-To: <20160930164424.GA4879@life-desktop>
On Fri, 30 Sep 2016, Anchal Jain wrote:
> Boolean tests do not need explicit comparison to true or false.
>
> Signed-off-by: Anchal Jain <anchalj109@gmail.com>
> ---
> drivers/staging/rtl8188eu/core/rtw_ap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8188eu/core/rtw_ap.c b/drivers/staging/rtl8188eu/core/rtw_ap.c
> index 79d326a..fbe9941 100644
> --- a/drivers/staging/rtl8188eu/core/rtw_ap.c
> +++ b/drivers/staging/rtl8188eu/core/rtw_ap.c
> @@ -767,7 +767,7 @@ static void start_bss_network(struct adapter *padapter, u8 *pbuf)
> update_hw_ht_param(padapter);
> }
>
> - if (pmlmepriv->cur_network.join_res != true) { /* setting only at first time */
> + if (pmlmepriv->cur_network.join_res) { /* setting only at first time */
It looks like you have inverted the sense of the test.
julia
> /* WEP Key will be set before this function, do not clear CAM. */
> if ((psecuritypriv->dot11PrivacyAlgrthm != _WEP40_) &&
> (psecuritypriv->dot11PrivacyAlgrthm != _WEP104_))
> --
> 1.9.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20160930164424.GA4879%40life-desktop.
> For more options, visit https://groups.google.com/d/optout.
>
prev parent reply other threads:[~2016-09-30 17:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-30 16:45 [PATCH 1/2] staging: rtl8188eu: core: rtw_ap: remove boolean comparison Anchal Jain
2016-09-30 17:32 ` Julia Lawall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.10.1609301931330.3399@hadrien \
--to=julia.lawall@lip6.fr \
--cc=anchalj109@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.