From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S933065AbbI3VjK (ORCPT <rfc822;w@1wt.eu>);
	Wed, 30 Sep 2015 17:39:10 -0400
Received: from www.linutronix.de ([62.245.132.108]:45676 "EHLO
	Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S932514AbbI3VjH (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 30 Sep 2015 17:39:07 -0400
Date: Wed, 30 Sep 2015 23:38:15 +0200 (CEST)
From: Thomas Gleixner <tglx@linutronix.de>
To: Kees Cook <keescook@chromium.org>
cc: Ingo Molnar <mingo@kernel.org>, Andy Lutomirski <luto@amacapital.net>,
        Dmitry Vyukov <dvyukov@google.com>,
        Andrey Ryabinin <ryabinin.a.a@gmail.com>,
        Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
        Andy Lutomirski <luto@kernel.org>, Borislav Petkov <bp@alien8.de>,
        Denys Vlasenko <dvlasenk@redhat.com>,
        "x86@kernel.org" <x86@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
        Kostya Serebryany <kcc@google.com>,
        Alexander Potapenko <glider@google.com>,
        Andrey Konovalov <andreyknvl@google.com>,
        Sasha Levin <sasha.levin@oracle.com>, Andi Kleen <ak@linux.intel.com>,
        kasan-dev <kasan-dev@googlegroups.com>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Andrew Morton <akpm@linux-foundation.org>,
        Al Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH v2] fs/proc: Don't expose absolute kernel addresses via
 wchan
In-Reply-To: <CAGXu5jLN8zPz4auLbM0xs6kca27ueeVxkUSgoEQsjwbD=e-UYg@mail.gmail.com>
Message-ID: <alpine.DEB.2.11.1509302337470.4500@nanos>
References: <1443430839-13225-1-git-send-email-dvyukov@google.com> <CAPAsAGwyUQc6UffyQ=vJSNwOYQWE9XMzK5dT__C4r5_+qEYfHA@mail.gmail.com> <CACT4Y+ZWgVz_4NEJbsZWYBHn91M7UNxMNUk_+SebtOfBAoN_LA@mail.gmail.com> <alpine.DEB.2.11.1509281830160.4500@nanos>
 <CALCETrWWsFB+aWKhadoaftNNjU=gRa15+7PXOR=3yrVzXuar6w@mail.gmail.com> <20150930071537.GA19048@gmail.com> <alpine.DEB.2.11.1509300934470.4500@nanos> <20150930135917.GA3285@gmail.com> <CAGXu5jLN8zPz4auLbM0xs6kca27ueeVxkUSgoEQsjwbD=e-UYg@mail.gmail.com>
User-Agent: Alpine 2.11 (DEB 23 2013-08-11)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
X-Linutronix-Spam-Score: -1.0
X-Linutronix-Spam-Level: -
X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required,  ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 30 Sep 2015, Kees Cook wrote:
> Probably should also update Documentation/filesystems/proc.txt with
> something like:
> 
> --- a/Documentation/filesystems/proc.txt
> +++ b/Documentation/filesystems/proc.txt
> @@ -310,7 +310,7 @@ Table 1-4: Contents of the stat files (as of 2.6.30-rc7)
>    blocked       bitmap of blocked signals
>    sigign        bitmap of ignored signals
>    sigcatch      bitmap of caught signals
> -  wchan         address where process went to sleep
> +  0             (place holder, was wchan, see /proc/PID/wchan instead)
>    0             (place holder)
>    0             (place holder)
>    exit_signal   signal to send to parent thread on exit

Good catch!

Thanks,

	tglx