From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Lars Schneider <larsxschneider@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] perf: accommodate for MacOSX
Date: Mon, 20 Jun 2016 08:45:29 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.20.1606200840350.22630@virtualbox> (raw)
In-Reply-To: <9A11C3D1-3DAC-489F-BDF9-F4D409E8D3F7@gmail.com>
Hi Lars,
On Sun, 19 Jun 2016, Lars Schneider wrote:
> > On 18 Jun 2016, at 15:03, Johannes Schindelin
> > <johannes.schindelin@gmx.de> wrote:
> >
> > As this developer has no access to MacOSX developer setups anymore,
> > Travis becomes the best bet to run performance tests on that OS.
>
> We don't run the performance tests on Travis CI right now.
> Maybe we should? With your patch below it should work, right?
It *should* work, but I'd be reluctant to run them as part of the CI: we
have no real chance to catch perf regressions as of now. So all it would
do would be to add load to Travis.
> I only saw one error on my local OS X machine here:
> https://github.com/git/git/blob/05219a1276341e72d8082d76b7f5ed394b7437a4/t/perf/p0000-perf-lib-sanity.sh#L26
Yeah, well, I should have been clearer in my commit message: this patch
allows the perf tests to *run*, not to *pass*... ;-)
> Does the export of foo not work properly on OS X? "$foo" is empty...
Sorry, as I said: I no longer have access to a dev setup running MacOSX.
Ciao,
Dscho
P.S.: Please save me time by deleting the remainder of the quoted mail
when it is irrelevant to your reply. Thanks!
next prev parent reply other threads:[~2016-06-20 6:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-18 13:03 [PATCH] perf: accommodate for MacOSX Johannes Schindelin
2016-06-19 16:56 ` Lars Schneider
2016-06-20 6:45 ` Johannes Schindelin [this message]
2016-06-20 19:48 ` Junio C Hamano
2016-06-21 7:57 ` Lars Schneider
2016-06-21 11:55 ` Johannes Schindelin
2016-06-21 12:49 ` Lars Schneider
2016-06-21 13:50 ` Johannes Schindelin
2016-06-21 13:53 ` [PATCH v2] " Johannes Schindelin
2016-06-21 18:03 ` Lars Schneider
2016-06-21 18:35 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1606200840350.22630@virtualbox \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=larsxschneider@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.