From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] revert: clarify seemingly bogus OPT_END repetition
Date: Wed, 6 Jul 2016 09:03:44 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.20.1607060901430.6426@virtualbox> (raw)
In-Reply-To: <20160705202820.GA14496@sigill.intra.peff.net>
Hi Peff,
On Tue, 5 Jul 2016, Jeff King wrote:
> By the way, I notice that the error message when concat fails is just:
>
> if (parse_options_concat(options, ARRAY_SIZE(options), cp_extra))
> die(_("program error"));
>
> Should this become:
>
> die("BUG: not enough room to concatenate options");
>
> as part of your BUG cleanups elsewhere?
Not really. I do not have time for a crusade through all of the die()
statements to determine whether they're really bug reports. You refer to
my clean-up of merge-recursive.c, right? That was a necessary prerequisite
for the patch to stop die()ing in case of errors.
Ciao,
Dscho
next prev parent reply other threads:[~2016-07-06 7:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-05 11:58 [PATCH] revert: clarify seemingly bogus OPT_END repetition Johannes Schindelin
2016-07-05 20:28 ` Jeff King
2016-07-05 20:44 ` Jeff King
2016-07-05 21:15 ` Jacob Keller
2016-07-06 7:01 ` Johannes Schindelin
2016-07-06 11:09 ` Michael J Gruber
2016-07-06 13:16 ` Over-/underquoting, was " Johannes Schindelin
2016-07-06 20:15 ` Jacob Keller
2016-07-09 15:34 ` Michael J Gruber
2016-07-09 23:35 ` Eric Wong
2016-07-06 7:28 ` Johannes Schindelin
2016-07-06 7:03 ` Johannes Schindelin [this message]
2016-07-06 10:48 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1607060901430.6426@virtualbox \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.