From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Gumbel, Matthew K" <matthew.k.gumbel@intel.com>,
"git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: [PATCH] commit: Optimize number of lstat() calls
Date: Sat, 4 Feb 2017 11:42:56 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.20.1702041142320.3496@virtualbox> (raw)
In-Reply-To: <xmqqd1ey5shc.fsf@gitster.mtv.corp.google.com>
Hi Junio,
On Fri, 3 Feb 2017, Junio C Hamano wrote:
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>
> > I could imagine that there is a third option we should consider, too: only
> > lstat() and update the paths that match the pathspec(s) provided on the
> > command line (this is the semantic meaning of the --only option, after
> > all: "I am only interested in these paths as far as this commit is
> > concerned"). What do you think?
>
> I wondered that myself when I read the first message from Matthew
> and noticed that we always refresh the entire index. But if it is
> OK to leave the entire index un-refreshed, that would even be
> simpler ;-)
Hah! You're right, that would be much simpler ;-)
Ciao,
Johannes
prev parent reply other threads:[~2017-02-04 10:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-03 23:22 [PATCH] commit: Optimize number of lstat() calls Gumbel, Matthew K
2017-02-03 23:38 ` Junio C Hamano
2017-02-04 6:50 ` Junio C Hamano
2017-02-04 0:35 ` Johannes Schindelin
2017-02-04 7:23 ` Junio C Hamano
2017-02-04 10:42 ` Johannes Schindelin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1702041142320.3496@virtualbox \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=matthew.k.gumbel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.