From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6387793530273660928 X-Received: by 10.46.69.136 with SMTP id s130mr417162lja.29.1487274269498; Thu, 16 Feb 2017 11:44:29 -0800 (PST) X-BeenThere: outreachy-kernel@googlegroups.com Received: by 10.28.135.198 with SMTP id j189ls1503039wmd.3.canary-gmail; Thu, 16 Feb 2017 11:44:28 -0800 (PST) X-Received: by 10.28.47.140 with SMTP id v134mr221294wmv.20.1487274268767; Thu, 16 Feb 2017 11:44:28 -0800 (PST) Return-Path: Received: from mail3-relais-sop.national.inria.fr (mail3-relais-sop.national.inria.fr. [192.134.164.104]) by gmr-mx.google.com with ESMTPS id y19si79112wmd.0.2017.02.16.11.44.28 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 16 Feb 2017 11:44:28 -0800 (PST) Received-SPF: neutral (google.com: 192.134.164.104 is neither permitted nor denied by domain of julia.lawall@lip6.fr) client-ip=192.134.164.104; Authentication-Results: gmr-mx.google.com; spf=neutral (google.com: 192.134.164.104 is neither permitted nor denied by domain of julia.lawall@lip6.fr) smtp.mailfrom=julia.lawall@lip6.fr X-IronPort-AV: E=Sophos;i="5.35,169,1484002800"; d="scan'208";a="213496329" Received: from 198.67.28.109.rev.sfr.net (HELO hadrien) ([109.28.67.198]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Feb 2017 20:44:27 +0100 Date: Thu, 16 Feb 2017 20:44:27 +0100 (CET) From: Julia Lawall X-X-Sender: jll@hadrien To: simran singhal cc: gregkh@linuxfoundation.org, outreachy-kernel@googlegroups.com, devel@driverdev.osuosl.org Subject: Re: [Outreachy kernel] In-Reply-To: <20170216194114.GA17810@singhal-Inspiron-5558> Message-ID: References: <20170216194114.GA17810@singhal-Inspiron-5558> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Fri, 17 Feb 2017, simran singhal wrote: > linux-kernel@vger.kernel.org > Bcc: > Subject: [PATCH 1/3] staging: rtl8192u: Replace symbolic permissions with > octal permissions > Reply-To: Your email did not come out well. This part should not be in the message. Try sending the message to yourself first, to be sure everything is ok. > WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. > Consider using octal permissions '0644'. > This warning is detected by checkpatch.pl It would be better to explain what you did and why, rather than just copying the checkpatch message. > Signed-off-by: simran singhal > --- > drivers/staging/rtl8192u/ieee80211/ieee80211_module.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c > index a9a92d8..2ebc320 100644 > --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c > +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c > @@ -283,7 +283,7 @@ int __init ieee80211_debug_init(void) > " proc directory\n"); > return -EIO; > } > - e = proc_create("debug_level", S_IRUGO | S_IWUSR, > + e = proc_create("debug_level", 0644, > ieee80211_proc, &fops); This could all be one line now. julia > if (!e) { > remove_proc_entry(DRV_NAME, init_net.proc_net); > -- > 2.7.4 > > -- > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. > To post to this group, send email to outreachy-kernel@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170216194114.GA17810%40singhal-Inspiron-5558. > For more options, visit https://groups.google.com/d/optout. >