Re: [Outreachy kernel] [PATCH] staging: dgnc: replace udelay with usleep_range

[Julia Lawall <julia.lawall@lip6.fr>]

On Mon, 27 Feb 2017, Aishwarya Pant wrote:

> Adding first patch for checkpatch warning on dgnc_cls.c -

What do you mean by "Adding first patch"?

Actually, commit messages should be written in the imperative (as you have
for the subject line), and should describe what you do and why.

> CHECK: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.txt

Also commit messages should be limited to around 70 characters or so per
line.

How did you choose 20 as the upper bound?

julia

>
> Signed-off-by: Aishwarya Pant <aishpant@gmail.com>
> ---
>  drivers/staging/dgnc/dgnc_cls.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/dgnc/dgnc_cls.c b/drivers/staging/dgnc/dgnc_cls.c
> index c20ffdd..2cf146e 100644
> --- a/drivers/staging/dgnc/dgnc_cls.c
> +++ b/drivers/staging/dgnc/dgnc_cls.c
> @@ -16,7 +16,7 @@
>  #include <linux/kernel.h>
>  #include <linux/sched.h>	/* For jiffies, task states */
>  #include <linux/interrupt.h>	/* For tasklet and interrupt structs/defines */
> -#include <linux/delay.h>	/* For udelay */
> +#include <linux/delay.h>	/* For usleep_range */
>  #include <linux/io.h>		/* For read[bwl]/write[bwl] */
>  #include <linux/serial.h>	/* For struct async_serial */
>  #include <linux/serial_reg.h>	/* For the various UART offsets */
> @@ -409,7 +409,7 @@ static void cls_assert_modem_signals(struct channel_t *ch)
>  	writeb(out, &ch->ch_cls_uart->mcr);
>
>  	/* Give time for the UART to actually drop the signals */
> -	udelay(10);
> +	usleep_range(10, 20);
>  }
>
>  static void cls_copy_data_from_queue_to_uart(struct channel_t *ch)
> @@ -631,7 +631,7 @@ static void cls_flush_uart_read(struct channel_t *ch)
>  	 * Presumably, this is a bug in this UART.
>  	 */
>
> -	udelay(10);
> +	usleep_range(10, 20);
>  }
>
>  /*
> @@ -1096,7 +1096,7 @@ static void cls_uart_init(struct channel_t *ch)
>
>  	writeb(UART_FCR_ENABLE_FIFO | UART_FCR_CLEAR_RCVR | UART_FCR_CLEAR_XMIT,
>  	       &ch->ch_cls_uart->isr_fcr);
> -	udelay(10);
> +	usleep_range(10, 20);
>
>  	ch->ch_flags |= (CH_FIFO_ENABLED | CH_TX_FIFO_EMPTY | CH_TX_FIFO_LWM);
>
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170226183806.GA3498%40aishwarya.
> For more options, visit https://groups.google.com/d/optout.
>