From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julia Lawall Subject: Re: [Outreachy kernel] [PATCH] staging: nvec: cleanup USLEEP_RANGE checkpatch checks Date: Thu, 2 Mar 2017 16:01:12 +0100 (CET) Message-ID: References: <20170302142418.GA16773@singhal-Inspiron-5558> Mime-Version: 1.0 Content-Type: multipart/mixed; BOUNDARY="8323329-521192090-1488466872=:3414" Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" To: SIMRAN SINGHAL Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, outreachy-kernel , linux-tegra@vger.kernel.org, ac100@lists.launchpad.net List-Id: linux-tegra@vger.kernel.org --8323329-521192090-1488466872=:3414 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT On Thu, 2 Mar 2017, SIMRAN SINGHAL wrote: > > > On Thursday, March 2, 2017 at 8:06:40 PM UTC+5:30, Julia Lawall wrote: > > > On Thu, 2 Mar 2017, simran singhal wrote: > > > Resolve strict checkpatch USLEEP_RANGE checks by converting > delays and > > sleeps as described in > ./Documentation/timers/timers-howto.txt. > > > > CHECK: usleep_range is preferred over udelay; see > Documentation/ > > timers/timers-howto.txt > > > > Signed-off-by: simran singhal > > --- > >  drivers/staging/nvec/nvec.c | 4 ++-- > >  1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/staging/nvec/nvec.c > b/drivers/staging/nvec/nvec.c > > index c1feccf..cd35e64 100644 > > --- a/drivers/staging/nvec/nvec.c > > +++ b/drivers/staging/nvec/nvec.c > > @@ -631,7 +631,7 @@ static irqreturn_t nvec_interrupt(int irq, > void *dev) > >                  break; > >          case 2:                /* first byte after command */ > >                  if (status == (I2C_SL_IRQ | RNW | RCVD)) { > > -                        udelay(33); > > +                        usleep_range(33, 100); > > How did you choose the upper limit. > > I believe that Greg previously suggested not to make these > changes if you > have no way to test them. > > Julia, After going through the reply given by Nicholas Mc Guire  > https://www.mail-archive.com/kernelnewbies@kernelnewbies.org/msg16464.html > in this reply he has mentioned that even the range of 10 microsecond is > enough, > so I prefer to take 100 as upper limit.   Than you for the link. It looks like he suggests to change 33 to 30-40, not to 33-100. In any case, you have three choices for this kind of issue: 1. Don't make the change, because you can't test the result 2. Make the change, and explain the commit log what your rationale is 3. Make the change, and explain below the --- that you have no idea what you are doing, and you are just proposing the patch as something concrete to start a discussion. But your preference is not a suitable justification. The hardware does something, and the choice can only really be made by the person who knows what it does. julia >   > Simran > > julia > > > >                          if (nvec->rx->data[0] != 0x01) { > >                                  dev_err(nvec->dev, > >                                          "Read without prior > read command\n"); > > @@ -718,7 +718,7 @@ static irqreturn_t nvec_interrupt(int irq, > void *dev) > >           * We experience less incomplete messages with this > delay than without > >           * it, but we don't know why. Help is appreciated. > >           */ > > -        udelay(100); > > +        usleep_range(100, 200); > > > >          return IRQ_HANDLED; > >  } > > -- > > 2.7.4 > > > > -- > > You received this message because you are subscribed to the > Google Groups "outreachy-kernel" group. > > To unsubscribe from this group and stop receiving emails from > it, send an email to outreachy-kern...@googlegroups.com. > > To post to this group, send email to > outreach...@googlegroups.com. > > To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/20170302142418.GA16773%4 > 0singhal-Inspiron-5558. > > For more options, visit https://groups.google.com/d/optout. > > > > -- > You received this message because you are subscribed to the Google Groups > "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to outreachy-kernel+unsubscribe@googlegroups.com. > To post to this group, send email to outreachy-kernel@googlegroups.com. > To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/b90bc602-cf06-4abb-bea2- > 6386d4976864%40googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > > --8323329-521192090-1488466872=:3414 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel --8323329-521192090-1488466872=:3414-- From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6392907056098050048 X-Received: by 10.25.234.202 with SMTP id y71mr1721822lfi.2.1488466883791; Thu, 02 Mar 2017 07:01:23 -0800 (PST) X-BeenThere: outreachy-kernel@googlegroups.com Received: by 10.46.14.1 with SMTP id 1ls766267ljo.45.gmail; Thu, 02 Mar 2017 07:01:22 -0800 (PST) X-Received: by 10.25.234.202 with SMTP id y71mr1721772lfi.2.1488466882717; Thu, 02 Mar 2017 07:01:22 -0800 (PST) Return-Path: Received: from mail3-relais-sop.national.inria.fr (mail3-relais-sop.national.inria.fr. [192.134.164.104]) by gmr-mx.google.com with ESMTPS id 14si797665wmn.2.2017.03.02.07.01.22 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 02 Mar 2017 07:01:22 -0800 (PST) Received-SPF: neutral (google.com: 192.134.164.104 is neither permitted nor denied by domain of julia.lawall@lip6.fr) client-ip=192.134.164.104; Authentication-Results: gmr-mx.google.com; spf=neutral (google.com: 192.134.164.104 is neither permitted nor denied by domain of julia.lawall@lip6.fr) smtp.mailfrom=julia.lawall@lip6.fr X-IronPort-AV: E=Sophos;i="5.35,231,1484002800"; d="scan'208";a="215332179" Received: from vaio-julia.rsr.lip6.fr ([132.227.76.33]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Mar 2017 16:01:21 +0100 Date: Thu, 2 Mar 2017 16:01:12 +0100 (CET) From: Julia Lawall X-X-Sender: jll@hadrien To: SIMRAN SINGHAL cc: outreachy-kernel , marvin24@gmx.de, gregkh@linuxfoundation.org, ac100@lists.launchpad.net, linux-tegra@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [Outreachy kernel] [PATCH] staging: nvec: cleanup USLEEP_RANGE checkpatch checks In-Reply-To: Message-ID: References: <20170302142418.GA16773@singhal-Inspiron-5558> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: multipart/mixed; BOUNDARY="8323329-521192090-1488466872=:3414" --8323329-521192090-1488466872=:3414 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT On Thu, 2 Mar 2017, SIMRAN SINGHAL wrote: > > > On Thursday, March 2, 2017 at 8:06:40 PM UTC+5:30, Julia Lawall wrote: > > > On Thu, 2 Mar 2017, simran singhal wrote: > > > Resolve strict checkpatch USLEEP_RANGE checks by converting > delays and > > sleeps as described in > ./Documentation/timers/timers-howto.txt. > > > > CHECK: usleep_range is preferred over udelay; see > Documentation/ > > timers/timers-howto.txt > > > > Signed-off-by: simran singhal > > --- > >  drivers/staging/nvec/nvec.c | 4 ++-- > >  1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/staging/nvec/nvec.c > b/drivers/staging/nvec/nvec.c > > index c1feccf..cd35e64 100644 > > --- a/drivers/staging/nvec/nvec.c > > +++ b/drivers/staging/nvec/nvec.c > > @@ -631,7 +631,7 @@ static irqreturn_t nvec_interrupt(int irq, > void *dev) > >                  break; > >          case 2:                /* first byte after command */ > >                  if (status == (I2C_SL_IRQ | RNW | RCVD)) { > > -                        udelay(33); > > +                        usleep_range(33, 100); > > How did you choose the upper limit. > > I believe that Greg previously suggested not to make these > changes if you > have no way to test them. > > Julia, After going through the reply given by Nicholas Mc Guire  > https://www.mail-archive.com/kernelnewbies@kernelnewbies.org/msg16464.html > in this reply he has mentioned that even the range of 10 microsecond is > enough, > so I prefer to take 100 as upper limit.   Than you for the link. It looks like he suggests to change 33 to 30-40, not to 33-100. In any case, you have three choices for this kind of issue: 1. Don't make the change, because you can't test the result 2. Make the change, and explain the commit log what your rationale is 3. Make the change, and explain below the --- that you have no idea what you are doing, and you are just proposing the patch as something concrete to start a discussion. But your preference is not a suitable justification. The hardware does something, and the choice can only really be made by the person who knows what it does. julia >   > Simran > > julia > > > >                          if (nvec->rx->data[0] != 0x01) { > >                                  dev_err(nvec->dev, > >                                          "Read without prior > read command\n"); > > @@ -718,7 +718,7 @@ static irqreturn_t nvec_interrupt(int irq, > void *dev) > >           * We experience less incomplete messages with this > delay than without > >           * it, but we don't know why. Help is appreciated. > >           */ > > -        udelay(100); > > +        usleep_range(100, 200); > > > >          return IRQ_HANDLED; > >  } > > -- > > 2.7.4 > > > > -- > > You received this message because you are subscribed to the > Google Groups "outreachy-kernel" group. > > To unsubscribe from this group and stop receiving emails from > it, send an email to outreachy-kern...@googlegroups.com. > > To post to this group, send email to > outreach...@googlegroups.com. > > To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/20170302142418.GA16773%4 > 0singhal-Inspiron-5558. > > For more options, visit https://groups.google.com/d/optout. > > > > -- > You received this message because you are subscribed to the Google Groups > "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to outreachy-kernel+unsubscribe@googlegroups.com. > To post to this group, send email to outreachy-kernel@googlegroups.com. > To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/b90bc602-cf06-4abb-bea2- > 6386d4976864%40googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > > --8323329-521192090-1488466872=:3414--