Re: [Outreachy kernel] [PATCH] staging: bcm2835-camera: replace kmalloc with kzalloc

[Julia Lawall <julia.lawall@lip6.fr>]

On Mon, 6 Mar 2017, Aishwarya Pant wrote:

> Replace two instances of kmalloc and memset with kzalloc in
> bcm2835-camera
>
> Signed-off-by: Aishwarya Pant <aishpant@gmail.com>
> ---
>  drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c b/drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c
> index 0f96ac8..cb8d129 100644
> --- a/drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c
> +++ b/drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c
> @@ -169,8 +169,7 @@ static struct mmal_msg_context *get_msg_context(struct vchiq_mmal_instance
>  	struct mmal_msg_context *msg_context;
>
>  	/* todo: should this be allocated from a pool to avoid kmalloc */

You could update the comment too.

> -	msg_context = kmalloc(sizeof(*msg_context), GFP_KERNEL);
> -	memset(msg_context, 0, sizeof(*msg_context));
> +	msg_context = kzalloc(sizeof(*msg_context), GFP_KERNEL);
>
>  	return msg_context;

This function could be just one line.

>  }
> @@ -1881,8 +1880,7 @@ int vchiq_mmal_init(struct vchiq_mmal_instance **out_instance)
>  		return -EIO;
>  	}
>
> -	instance = kmalloc(sizeof(*instance), GFP_KERNEL);
> -	memset(instance, 0, sizeof(*instance));
> +	instance = kzalloc(sizeof(*instance), GFP_KERNEL);

This code should detect the case where the result of kzalloc is NULL and
return -ENOMEM.

julia

>  	mutex_init(&instance->vchiq_mutex);
>  	mutex_init(&instance->bulk_mutex);
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170306062310.GA17005%40aishwarya.
> For more options, visit https://groups.google.com/d/optout.
>