Re: [Outreachy kernel] [PATCH] staging: rtl8188eu: remove unneeded conversions to bool

[Julia Lawall <julia.lawall@lip6.fr>]

On Fri, 22 Sep 2017, Aishwarya Pant wrote:

> On Fri, Sep 22, 2017 at 11:47:44AM +0200, Julia Lawall wrote:
> >
> >
> > On Fri, 22 Sep 2017, Aishwarya Pant wrote:
> >
> > > Patch suppresses the following warning issued by coccicheck:
> > > WARNING: conversion to bool not needed here
> > >
> > > Signed-off-by: Aishwarya Pant <aishpant@gmail.com>
> >
> > Acked-by: Julia Lawall <julia.lawall@lip6.fr>
>
> Dropping this patch to include it in a clean up patch set.
>
> Julia, I can include this ack when I add it to the patch set?

Yes, that part of the patch was fine.

julia

>
> >
> >
> > > ---
> > >  drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 8 ++++----
> > >  1 file changed, 4 insertions(+), 4 deletions(-)
> > >
> > > diff --git a/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c b/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c
> > > index 52f31c7..2db2ca6 100644
> > > --- a/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c
> > > +++ b/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c
> > > @@ -707,7 +707,7 @@ static int issue_probereq_ex(struct adapter *padapter,
> > >  	unsigned long start = jiffies;
> > >
> > >  	do {
> > > -		ret = issue_probereq(padapter, pssid, da, wait_ms > 0 ? true : false);
> > > +		ret = issue_probereq(padapter, pssid, da, wait_ms > 0);
> > >
> > >  		i++;
> > >
> > > @@ -1283,7 +1283,7 @@ int issue_nulldata(struct adapter *padapter, unsigned char *da, unsigned int pow
> > >  		da = pnetwork->MacAddress;
> > >
> > >  	do {
> > > -		ret = _issue_nulldata(padapter, da, power_mode, wait_ms > 0 ? true : false);
> > > +		ret = _issue_nulldata(padapter, da, power_mode, wait_ms > 0);
> > >
> > >  		i++;
> > >
> > > @@ -1410,7 +1410,7 @@ int issue_qos_nulldata(struct adapter *padapter, unsigned char *da, u16 tid, int
> > >  		da = pnetwork->MacAddress;
> > >
> > >  	do {
> > > -		ret = _issue_qos_nulldata(padapter, da, tid, wait_ms > 0 ? true : false);
> > > +		ret = _issue_qos_nulldata(padapter, da, tid, wait_ms > 0);
> > >
> > >  		i++;
> > >
> > > @@ -1517,7 +1517,7 @@ static int issue_deauth_ex(struct adapter *padapter, u8 *da,
> > >  	unsigned long start = jiffies;
> > >
> > >  	do {
> > > -		ret = _issue_deauth(padapter, da, reason, wait_ms > 0 ? true : false);
> > > +		ret = _issue_deauth(padapter, da, reason, wait_ms > 0);
> > >
> > >  		i++;
> > >
> > > --
> > > 2.7.4
> > >
> > > --
> > > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> > > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > > To post to this group, send email to outreachy-kernel@googlegroups.com.
> > > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170922094052.GA29313%40aishwarya.
> > > For more options, visit https://groups.google.com/d/optout.
> > >
>