From: Thomas Gleixner <tglx@linutronix.de>
To: TimGuo <timguo@zhaoxin.com>
Cc: mingo@redhat.com, hpa@zytor.com, mingo@kernel.org,
x86@kernel.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org, brucechang@via-alliance.com,
cooperyan@zhaoxin.com, qiyuanwang@zhaoxin.com,
benjaminpan@viatech.com
Subject: Re: [PATCH] x86/centaur: Mark TSC invariant
Date: Mon, 15 Jan 2018 10:49:04 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.20.1801151044520.1810@nanos> (raw)
In-Reply-To: <1515980145-3693-1-git-send-email-timguo@zhaoxin.com>
On Mon, 15 Jan 2018, TimGuo wrote:
> Centaur CPU has a constant frequency TSC and that TSC does not stop in C-States.
> But because the flags are not set for that CPU, the TSC is treated as non constant
> frequency and assumed to stop in C-States, which makes it an unreliable and unusable
> clock source. Setting those flags tells the kernel that the TSC is usable, so it
> will select it over HPET. The effect of this is that reading time stamps (from kernel
> or userspace) will be faster and more efficient.
>
> Signed-off-by: TimGuo <timguo@zhaoxin.com>
> ---
> arch/x86/kernel/cpu/centaur.c | 4 ++++
> drivers/acpi/processor_idle.c | 1 +
> 2 files changed, 5 insertions(+)
>
> diff --git a/arch/x86/kernel/cpu/centaur.c b/arch/x86/kernel/cpu/centaur.c
> index 68bc6d9..c578cd2 100644
> --- a/arch/x86/kernel/cpu/centaur.c
> +++ b/arch/x86/kernel/cpu/centaur.c
> @@ -106,6 +106,10 @@ static void early_init_centaur(struct cpuinfo_x86 *c)
> #ifdef CONFIG_X86_64
> set_cpu_cap(c, X86_FEATURE_SYSENTER32);
This is still white space damaged, i.e. TAB is converted to spaces.
Please talk to your IT departement.
Thanks,
tglx
next prev parent reply other threads:[~2018-01-15 9:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-15 1:35 [PATCH] x86/centaur: Mark TSC invariant TimGuo
2018-01-15 9:49 ` Thomas Gleixner [this message]
2018-01-24 18:26 ` Alan Cox
-- strict thread matches above, loose matches on Subject: below --
2018-01-22 10:14 davidwang
2018-01-10 10:27 (unknown), TimGuo
2018-01-14 12:06 ` [PATCH] x86/centaur: Mark TSC invariant Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1801151044520.1810@nanos \
--to=tglx@linutronix.de \
--cc=benjaminpan@viatech.com \
--cc=brucechang@via-alliance.com \
--cc=cooperyan@zhaoxin.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=qiyuanwang@zhaoxin.com \
--cc=timguo@zhaoxin.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.