From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6612504415220793344 X-Received: by 2002:a2e:3c08:: with SMTP id j8-v6mr431761lja.10.1539593964183; Mon, 15 Oct 2018 01:59:24 -0700 (PDT) X-BeenThere: outreachy-kernel@googlegroups.com Received: by 2002:a19:9681:: with SMTP id y123-v6ls459711lfd.20.gmail; Mon, 15 Oct 2018 01:59:23 -0700 (PDT) X-Google-Smtp-Source: ACcGV61cZWaeuTlgN5sNF2sxjNq/e6pmTSxCUtE2uwy5lv3IbognI3u2VrFwiGoQGbE+88+rtWtu X-Received: by 2002:a19:d807:: with SMTP id p7-v6mr418870lfg.5.1539593963269; Mon, 15 Oct 2018 01:59:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1539593963; cv=none; d=google.com; s=arc-20160816; b=UCF3YxkVPwIFN1vYxWV1+K/rpEcJKf5HSHeH4WviQtt7Krgc5Xi9gHoAzTK8o/4HHM BfeEZztd0I57dBuG8Zv7feYcJbK7q2XLhiuZvuzyFkkh8Um8QxDNgRXkyloJ9iEAvQOE PA/DXLytItyt5FmhbhHgFYCycHTvlwTN7mc+vVexvjIYB+jUK51LgFZWNSpP9dGkbwcR CqzXFAY1S7RbujP9VV2gPkC9g3FZ1ObE2n6v1sJtiLwGGeHuKOioQt34xW28GzcriRXf iWq3/1C9BPA8vxSzao+1kt7Q+hqhcGdFf+/pUWVHwHxDI75tQWRElvtVv9JHmoQKkEz7 Ftmw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:user-agent:references:message-id:in-reply-to:subject :cc:to:from:date; bh=QIhT61jvv4F5/A0yhI11AmUGwghr0vekfOsWqAo96aU=; b=YcF9nRjpdw7/Q8BbDOEr056bzX5nLw7wcnRRG3BU3pXW5klF9304qtqUZKgKhXWUbj Ur2qEXA75TDRAvbtpk2DCPNNOZw7qLlZMFPNhhn4RsSB9VOZhEQnoEPsjbNJaTUPHN3E ekkAL2xjoCAmYqA33kTZrLUBICTpPqtYdtllveMK1QWKCuB85mwp9X7Vvt/5q6Mm5SvR DSCRXHfc24N7q6dcWucwzL8diE+HGkKgm1oqgHl+pngnpreu056fENIP+Z9fnj7szndw /d0CEyd5MfqAno89/tDrDOjrE57gzFSrMWTB74yote6tnvSuzNPGIY7TRXOlsSw589yT ncMw== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=neutral (google.com: 192.134.164.104 is neither permitted nor denied by domain of julia.lawall@lip6.fr) smtp.mailfrom=julia.lawall@lip6.fr Return-Path: Received: from mail3-relais-sop.national.inria.fr (mail3-relais-sop.national.inria.fr. [192.134.164.104]) by gmr-mx.google.com with ESMTPS id h20-v6si408836ljj.5.2018.10.15.01.59.23 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 15 Oct 2018 01:59:23 -0700 (PDT) Received-SPF: neutral (google.com: 192.134.164.104 is neither permitted nor denied by domain of julia.lawall@lip6.fr) client-ip=192.134.164.104; Authentication-Results: gmr-mx.google.com; spf=neutral (google.com: 192.134.164.104 is neither permitted nor denied by domain of julia.lawall@lip6.fr) smtp.mailfrom=julia.lawall@lip6.fr X-IronPort-AV: E=Sophos;i="5.54,384,1534802400"; d="scan'208";a="282085304" Received: from vaio-julia.rsr.lip6.fr ([132.227.76.33]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Oct 2018 10:59:22 +0200 Date: Mon, 15 Oct 2018 10:59:18 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Bhanusree Pola cc: outreachy-kernel@googlegroups.com, Eric Anholt , Stefan Wahren , Greg Kroah-Hartman , Florian Fainelli , Ray Jui , Scott Branden Subject: Re: [Outreachy kernel] In-Reply-To: <20181015085307.GA15896@aakashd-VirtualBox> Message-ID: References: <20181015085307.GA15896@aakashd-VirtualBox> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Mon, 15 Oct 2018, Bhanusree Pola wrote: > bcm-kernel-feedback-list@broadcom.com > Bcc: > Subject: [Outreachy Kernel][PATCH v2] staging: bcm2835-camera: Remove 'ret' > variable > Reply-To: This didn't work out properly. Please first send the message to yourself to be sure it is ok, and then try again. julia > > Return value to be returned without using extra variable 'ret'. > Generated by Cocinelli semantic patch ret.cocci > The following is the ret.cocci semantic patch used: > > @@ > local idexpression ret; > expression e; > @@ > > -ret = > +return > e; > -return ret; > > Signed-off-by: Bhanusree Pola > --- > > changelog: > > v2: Include semantic patch used in the commit message > > drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c b/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c > index c04bdf0..a124f51 100644 > --- a/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c > +++ b/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c > @@ -1510,7 +1510,6 @@ static int set_camera_parameters(struct vchiq_mmal_instance *instance, > struct vchiq_mmal_component *camera, > struct bm2835_mmal_dev *dev) > { > - int ret; > struct mmal_parameter_camera_config cam_config = { > .max_stills_w = dev->max_width, > .max_stills_h = dev->max_height, > @@ -1526,10 +1525,9 @@ static int set_camera_parameters(struct vchiq_mmal_instance *instance, > .use_stc_timestamp = MMAL_PARAM_TIMESTAMP_MODE_RAW_STC > }; > > - ret = vchiq_mmal_port_parameter_set(instance, &camera->control, > + return vchiq_mmal_port_parameter_set(instance, &camera->control, > MMAL_PARAMETER_CAMERA_CONFIG, > &cam_config, sizeof(cam_config)); > - return ret; > } > > #define MAX_SUPPORTED_ENCODINGS 20 > -- > 2.7.4 > > -- > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. > To post to this group, send email to outreachy-kernel@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20181015085307.GA15896%40aakashd-VirtualBox. > For more options, visit https://groups.google.com/d/optout. >