Re: [Outreachy kernel] [Outreachy Kernel][PATCH] First clean-up patch

[Julia Lawall <julia.lawall@lip6.fr>]

Please go back and read the tutorial about how to create a subject line.
The subject line will end up part of the git history, so its form is
important.

On Mon, 4 Mar 2019, Daniela Mormocea wrote:

> Fixed alignment issue with parenthesis.

The log message should be in the imperative.  So Fix instead of Fixed.
Also it should say what you did and why.  Fix somehow describes the impact
that you hope to have, but it doesn't really say concretely what you did.

julia

> Signed-off-by: Daniela Mormocea <daniela.mormocea@gmail.com>
> ---
>  drivers/staging/wlan-ng/cfg80211.c | 9 +++------
>  1 file changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/wlan-ng/cfg80211.c b/drivers/staging/wlan-ng/cfg80211.c
> index 8a862f7..7c4e8f1f8 100644
> --- a/drivers/staging/wlan-ng/cfg80211.c
> +++ b/drivers/staging/wlan-ng/cfg80211.c
> @@ -332,8 +332,7 @@ static int prism2_scan(struct wiphy *wiphy,
>  		(i < request->n_channels) && i < ARRAY_SIZE(prism2_channels);
>  		i++)
>  		msg1.channellist.data.data[i] =
> -			ieee80211_frequency_to_channel(
> -				request->channels[i]->center_freq);
> +			ieee80211_frequency_to_channel(request->channels[i]->center_freq);
>  	msg1.channellist.data.len = request->n_channels;
>
>  	msg1.maxchanneltime.data = 250;
> @@ -372,11 +371,9 @@ static int prism2_scan(struct wiphy *wiphy,
>  			(const u8 *)&msg2.bssid.data.data,
>  			msg2.timestamp.data, msg2.capinfo.data,
>  			msg2.beaconperiod.data,
> -			ie_buf,
> -			ie_len,
> +			ie_buf, ie_len,
>  			(msg2.signal.data - 65536) * 100, /* Conversion to signed type */
> -			GFP_KERNEL
> -		);
> +			GFP_KERNEL);
>
>  		if (!bss) {
>  			err = -ENOMEM;
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20190304145801.GA28407%40pthm.
> For more options, visit https://groups.google.com/d/optout.
>