Re: [Outreachy kernel][PATCH v2]staging:comedi:comedi_pci.h Prefer a maximum 75 chars per line

[Julia Lawall <julia.lawall@lip6.fr>]

On Sat, 6 Oct 2018, Bhanusree Pola wrote:

> comedi_pci_auto_config() function prototype is exceeding more than
> 75 characters per line.Adjusted to 75 chars to improve readability
> and also adjusted the arguments to match open parantheses.

Use the imperative and put at least one space after punctuation.

>
> Signed-off-by: Bhanusree Pola <bhanusreemahesh@gmail.com>
> ---
>  drivers/staging/comedi/comedi_pci.h | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/comedi/comedi_pci.h b/drivers/staging/comedi/comedi_pci.h
> index 4e069440cbdc..d89273e43cea 100644
> --- a/drivers/staging/comedi/comedi_pci.h
> +++ b/drivers/staging/comedi/comedi_pci.h
> @@ -31,7 +31,8 @@ int comedi_pci_enable(struct comedi_device *dev);
>  void comedi_pci_disable(struct comedi_device *dev);
>  void comedi_pci_detach(struct comedi_device *dev);
>
> -int comedi_pci_auto_config(struct pci_dev *pcidev, struct comedi_driver *driver,
> +int comedi_pci_auto_config(struct pci_dev *pcidev,
> +			   struct comedi_driver *driver,
>  			   unsigned long context);
>  void comedi_pci_auto_unconfig(struct pci_dev *pcidev);
>
> @@ -41,7 +42,7 @@ void comedi_pci_driver_unregister(struct comedi_driver *comedi_driver,
>  				  struct pci_driver *pci_driver);
>
>  /**
> - * module_comedi_pci_driver() - Helper macro for registering a comedi PCI driver
> + * module_comedi_pci_driver()-Helper macro to register a comedi PCI driver

The log message doesn't say anything about this change.  The change is not
an improvement either,  Just move the word "driver" to the next line.

julia

>   * @__comedi_driver: comedi_driver struct
>   * @__pci_driver: pci_driver struct
>   *
> --
> 2.17.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20181006111404.GA13951%40veda-VGN-CS3AGH-R.
> For more options, visit https://groups.google.com/d/optout.
>