Re: [Outreachy kernel] [PATCH] staging: greybus: Add extra space around OR operator

[Julia Lawall <julia.lawall@lip6.fr>]

On Fri, 2 Nov 2018, Ioannis Valasakis wrote:

> Add extra spaces around the OR operator.

"extra" sounds superfluous.  Add spaces around the | operator.

julia

> Reported by checkpatch.
>
> Signed-off-by: Ioannis Valasakis <code@wizofe.uk>
> ---
>  drivers/staging/greybus/greybus_protocols.h | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/greybus/greybus_protocols.h b/drivers/staging/greybus/greybus_protocols.h
> index f38f4a8db2b7..5783f715bdc2 100644
> --- a/drivers/staging/greybus/greybus_protocols.h
> +++ b/drivers/staging/greybus/greybus_protocols.h
> @@ -866,10 +866,10 @@ struct gb_pwm_disable_request {
>  /* Should match up with modes in linux/spi/spi.h */
>  #define GB_SPI_MODE_CPHA		0x01		/* clock phase */
>  #define GB_SPI_MODE_CPOL		0x02		/* clock polarity */
> -#define GB_SPI_MODE_MODE_0		(0|0)		/* (original MicroWire) */
> -#define GB_SPI_MODE_MODE_1		(0|GB_SPI_MODE_CPHA)
> -#define GB_SPI_MODE_MODE_2		(GB_SPI_MODE_CPOL|0)
> -#define GB_SPI_MODE_MODE_3		(GB_SPI_MODE_CPOL|GB_SPI_MODE_CPHA)
> +#define GB_SPI_MODE_MODE_0		(0 | 0)		/* (original MicroWire) */
> +#define GB_SPI_MODE_MODE_1		(0 | GB_SPI_MODE_CPHA)
> +#define GB_SPI_MODE_MODE_2		(GB_SPI_MODE_CPOL | 0)
> +#define GB_SPI_MODE_MODE_3		(GB_SPI_MODE_CPOL | GB_SPI_MODE_CPHA)
>  #define GB_SPI_MODE_CS_HIGH		0x04		/* chipselect active high? */
>  #define GB_SPI_MODE_LSB_FIRST		0x08		/* per-word bits-on-wire */
>  #define GB_SPI_MODE_3WIRE		0x10		/* SI/SO signals shared */
> --
> 2.19.1
>
>
> --
> ta
> ioannis
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20181102233924.GA16172%40kvasir.local.
> For more options, visit https://groups.google.com/d/optout.
>