Re: [Outreachy kernel] [PATCH] staging: greybus: remove extra space before tab

[Julia Lawall <julia.lawall@lip6.fr>]

[-- Attachment #1: Type: text/plain, Size: 3194 bytes --]



On Sat, 3 Nov 2018, tungolcild@gmail.com wrote:

> On Saturday, November 3, 2018 at 6:57:54 AM UTC, Julia Lawall wrote:
>
>
>       On Fri, 2 Nov 2018, Ioannis Valasakis wrote:
>
>       > Remove extra spaces before the tab character inside a comment section.
>       > Reported by checkpatch.
>       >
>       > Signed-off-by: Ioannis Valasakis <co...@wizofe.uk>
>       > ---
>       >  drivers/staging/greybus/greybus_protocols.h | 4 ++--
>
>       You seem to have sent three patches on this file.  Greg will want them to
>       be in a series, to reduce ambiguity about how they should be applied.
>
>       Likewise for the other files.
>
>       julia
>
>
> By series do you mean that I need to create a patchset? 

Yes, that makes the application order clear.

julia

>
> ta
> ioannis 
>       >  1 file changed, 2 insertions(+), 2 deletions(-)
>       >
>       > diff --git a/drivers/staging/greybus/greybus_protocols.h b/drivers/staging/greybus/greybus_protocols.h
>       > index 5783f715bdc2..429a952c5200 100644
>       > --- a/drivers/staging/greybus/greybus_protocols.h
>       > +++ b/drivers/staging/greybus/greybus_protocols.h
>       > @@ -918,8 +918,8 @@ struct gb_spi_device_config_response {
>       >   *        0 the default (from @spi_device) is used.
>       >   * @len: size of rx and tx buffers (in bytes)
>       >   * @delay_usecs: microseconds to delay after this transfer before (optionally)
>       > - *         changing the chipselect status, then starting the next transfer or
>       > - *         completing this spi_message.
>       > + *        changing the chipselect status, then starting the next transfer or
>       > + *        completing this spi_message.
>       >   * @cs_change: affects chipselect after this transfer completes
>       >   * @bits_per_word: select a bits_per_word other than the device default for this
>       >   *        transfer. If 0 the default (from @spi_device) is used.
>       > --
>       > 2.19.1
>       >
>       >
>       > --
>       > ta
>       > ioannis
>       >
>       > --
>       > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
>       > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kern...@googlegroups.com.
>       > To post to this group, send email to outreach...@googlegroups.com.
>       > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20181102234508.GA27353%40kvasir.local.
>       > For more options, visit https://groups.google.com/d/optout.
>       >
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/a43ce3ad-9062-4294-a23c-f9898fe44276%40googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>
>