From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7F25C43613 for ; Thu, 20 Jun 2019 19:12:34 +0000 (UTC) Received: from isis.lip6.fr (isis.lip6.fr [132.227.60.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8ABD820673 for ; Thu, 20 Jun 2019 19:12:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8ABD820673 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lip6.fr Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=cocci-bounces@systeme.lip6.fr Received: from systeme.lip6.fr (systeme.lip6.fr [132.227.104.7]) by isis.lip6.fr (8.15.2/8.15.2) with ESMTP id x5KJCMHt014516; Thu, 20 Jun 2019 21:12:22 +0200 (CEST) Received: from systeme.lip6.fr (systeme.lip6.fr [127.0.0.1]) by systeme.lip6.fr (Postfix) with ESMTP id E91887781; Thu, 20 Jun 2019 21:12:21 +0200 (CEST) Received: from isis.lip6.fr (isis.lip6.fr [132.227.60.2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by systeme.lip6.fr (Postfix) with ESMTPS id 24F607778 for ; Thu, 20 Jun 2019 21:12:21 +0200 (CEST) Received: from mail2-relais-roc.national.inria.fr (mail2-relais-roc.national.inria.fr [192.134.164.83]) by isis.lip6.fr (8.15.2/8.15.2) with ESMTP id x5KJCKX0000010 for ; Thu, 20 Jun 2019 21:12:20 +0200 (CEST) X-IronPort-AV: E=Sophos;i="5.63,397,1557180000"; d="scan'208";a="388396700" Received: from abo-12-105-68.mrs.modulonet.fr (HELO hadrien) ([85.68.105.12]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Jun 2019 21:12:20 +0200 Date: Thu, 20 Jun 2019 21:12:20 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Markus Elfring In-Reply-To: <34d528db-5582-5fe2-caeb-89bcb07a1d30@web.de> Message-ID: References: <05d85182-7ec3-8fc1-4bcd-fd2528de3a40@web.de> <34d528db-5582-5fe2-caeb-89bcb07a1d30@web.de> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 X-Greylist: Sender IP whitelisted, Sender e-mail whitelisted, not delayed by milter-greylist-4.4.3 (isis.lip6.fr [132.227.60.2]); Thu, 20 Jun 2019 21:12:22 +0200 (CEST) X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.4.3 (isis.lip6.fr [132.227.60.2]); Thu, 20 Jun 2019 21:12:20 +0200 (CEST) X-Scanned-By: MIMEDefang 2.78 on 132.227.60.2 X-Scanned-By: MIMEDefang 2.78 on 132.227.60.2 Cc: Michal Marek , kernel-janitors@vger.kernel.org, Nicolas Palix , LKML , Ding Xiang , Coccinelle Subject: Re: [Cocci] Coccinelle: Add a SmPL script for the reconsideration of redundant dev_err() calls X-BeenThere: cocci@systeme.lip6.fr X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: cocci-bounces@systeme.lip6.fr Errors-To: cocci-bounces@systeme.lip6.fr On Thu, 20 Jun 2019, Markus Elfring wrote: > >> +@display depends on context@ > >> +expression e; > >> +@@ > >> + e = devm_ioremap_resource(...); > >> + if (IS_ERR(e)) > >> + { > >> +* dev_err(...); > >> + return (...); > >> + } > > > > Why do you assume that there is exactly one dev_err and one return after > > the test? > > I propose to start with the addition of a simple source code search pattern. > Would you prefer to clarify a more advanced approach? I think that something like if (IS_ERR(e)) { <+... *dev_err(...) ...+> } would be more appropriate. Whether there is a return or not doesn't really matter. > > > >> +@script:python to_do depends on org@ > >> +p << or.p; > >> +@@ > >> +coccilib.org.print_todo(p[0], > >> + "WARNING: An error message is probably not needed here because the previously called function contains appropriate error reporting.") > > > > "the previously called function" would be better as "devm_ioremap_resource". > > Would you like to get the relevant function name dynamically determined? I have no idea what you consider "the relevant function name" to be. If it is always devm_ioremap_resource then it would seem that it does not need to be dynamically determined. julia _______________________________________________ Cocci mailing list Cocci@systeme.lip6.fr https://systeme.lip6.fr/mailman/listinfo/cocci From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julia Lawall Date: Thu, 20 Jun 2019 19:12:20 +0000 Subject: Re: Coccinelle: Add a SmPL script for the reconsideration of redundant dev_err() calls Message-Id: List-Id: References: <05d85182-7ec3-8fc1-4bcd-fd2528de3a40@web.de> <34d528db-5582-5fe2-caeb-89bcb07a1d30@web.de> In-Reply-To: <34d528db-5582-5fe2-caeb-89bcb07a1d30@web.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Markus Elfring Cc: Michal Marek , kernel-janitors@vger.kernel.org, Nicolas Palix , LKML , Ding Xiang , Coccinelle On Thu, 20 Jun 2019, Markus Elfring wrote: > >> +@display depends on context@ > >> +expression e; > >> +@@ > >> + e = devm_ioremap_resource(...); > >> + if (IS_ERR(e)) > >> + { > >> +* dev_err(...); > >> + return (...); > >> + } > > > > Why do you assume that there is exactly one dev_err and one return after > > the test? > > I propose to start with the addition of a simple source code search pattern. > Would you prefer to clarify a more advanced approach? I think that something like if (IS_ERR(e)) { <+... *dev_err(...) ...+> } would be more appropriate. Whether there is a return or not doesn't really matter. > > > >> +@script:python to_do depends on org@ > >> +p << or.p; > >> +@@ > >> +coccilib.org.print_todo(p[0], > >> + "WARNING: An error message is probably not needed here because the previously called function contains appropriate error reporting.") > > > > "the previously called function" would be better as "devm_ioremap_resource". > > Would you like to get the relevant function name dynamically determined? I have no idea what you consider "the relevant function name" to be. If it is always devm_ioremap_resource then it would seem that it does not need to be dynamically determined. julia From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B1E0C43613 for ; Thu, 20 Jun 2019 19:12:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E957220665 for ; Thu, 20 Jun 2019 19:12:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726378AbfFTTMW (ORCPT ); Thu, 20 Jun 2019 15:12:22 -0400 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:16227 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725897AbfFTTMW (ORCPT ); Thu, 20 Jun 2019 15:12:22 -0400 X-IronPort-AV: E=Sophos;i="5.63,397,1557180000"; d="scan'208";a="388396700" Received: from abo-12-105-68.mrs.modulonet.fr (HELO hadrien) ([85.68.105.12]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Jun 2019 21:12:20 +0200 Date: Thu, 20 Jun 2019 21:12:20 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Markus Elfring cc: Julia Lawall , kernel-janitors@vger.kernel.org, Gilles Muller , Masahiro Yamada , Michal Marek , Nicolas Palix , Coccinelle , LKML , Ding Xiang Subject: Re: Coccinelle: Add a SmPL script for the reconsideration of redundant dev_err() calls In-Reply-To: <34d528db-5582-5fe2-caeb-89bcb07a1d30@web.de> Message-ID: References: <05d85182-7ec3-8fc1-4bcd-fd2528de3a40@web.de> <34d528db-5582-5fe2-caeb-89bcb07a1d30@web.de> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 20 Jun 2019, Markus Elfring wrote: > >> +@display depends on context@ > >> +expression e; > >> +@@ > >> + e = devm_ioremap_resource(...); > >> + if (IS_ERR(e)) > >> + { > >> +* dev_err(...); > >> + return (...); > >> + } > > > > Why do you assume that there is exactly one dev_err and one return after > > the test? > > I propose to start with the addition of a simple source code search pattern. > Would you prefer to clarify a more advanced approach? I think that something like if (IS_ERR(e)) { <+... *dev_err(...) ...+> } would be more appropriate. Whether there is a return or not doesn't really matter. > > > >> +@script:python to_do depends on org@ > >> +p << or.p; > >> +@@ > >> +coccilib.org.print_todo(p[0], > >> + "WARNING: An error message is probably not needed here because the previously called function contains appropriate error reporting.") > > > > "the previously called function" would be better as "devm_ioremap_resource". > > Would you like to get the relevant function name dynamically determined? I have no idea what you consider "the relevant function name" to be. If it is always devm_ioremap_resource then it would seem that it does not need to be dynamically determined. julia