From: Julia Lawall <julia.lawall@lip6.fr>
To: Paul Chaignon <paul.chaignon@gmail.com>
Cc: cocci@systeme.lip6.fr
Subject: Re: [Cocci] SmPL highlighting on GitHub and GitLab
Date: Tue, 27 Aug 2019 22:44:43 +0800 (CST) [thread overview]
Message-ID: <alpine.DEB.2.21.1908272238360.2475@hadrien> (raw)
In-Reply-To: <20190827143039.GA19250@Nover>
On Tue, 27 Aug 2019, Paul Chaignon wrote:
> Hello dear Coccinelle community,
>
> Since a few hours ago, SmPL code is detected and highlighted on GitHub.
> Examples [1, 2] are visible in the Linux repository. Other repositories
> should receive highlighting when they'll be updated (after a git push).
> Highlighting on GitLab should follow if/when they update their Linguist
> dependency.
>
> This change follows an update to the Linguist library [3], used to detect
> languages on GitHub and GitLab. At the moment, all .cocci files are
> detected as SmPL. The grammar for highlighting [4] was written by John
> Gardner and should also work for the Atom editor. If you want to change
> the color, aliases, or extensions associated with SmPL, we'd welcome pull
> requests to Linguist and I'm confident John would too for the grammar!
Wow, thanks for this!
However, I don't see anything for [1], only for [2].
As far as I can see, the - code has a background and the + code does not.
Is there a reason for that?
It could also be good to use a different color for the * code; I've been
using purple.
I also use blue for the @@s and black for the metavariable declarations,
but I find your color choices rather appealing in this case.
If there are no further color suggestions on the list, I will look into
how to make a pull request.
Thanks!
julia
>
> Regards,
> Paul Chaignon
>
> 1 - https://github.com/torvalds/linux/blob/master/scripts/coccinelle/api/d_find_alias.cocci
> 2 - https://github.com/torvalds/linux/blob/master/scripts/coccinelle/misc/boolreturn.cocci
> 3 - https://github.com/github/linguist
> 4 - https://github.com/Alhadis/language-etc/blob/master/grammars/smpl.cson
> _______________________________________________
> Cocci mailing list
> Cocci@systeme.lip6.fr
> https://systeme.lip6.fr/mailman/listinfo/cocci
>
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci
next prev parent reply other threads:[~2019-08-27 14:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-27 14:30 [Cocci] SmPL highlighting on GitHub and GitLab Paul Chaignon
2019-08-27 14:44 ` Julia Lawall [this message]
2019-08-28 7:40 ` Paul Chaignon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1908272238360.2475@hadrien \
--to=julia.lawall@lip6.fr \
--cc=cocci@systeme.lip6.fr \
--cc=paul.chaignon@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.