Re: [Outreachy kernel] Re: [PATCH] staging : comedi : dt2801 : remove old unused code

[Julia Lawall <julia.lawall@inria.fr>]

[-- Attachment #1: Type: text/plain, Size: 3248 bytes --]



On Tue, 10 Mar 2020, Deepak Varma wrote:

> True. I added those manually to be sure. Would you suggest I resubmit v4 or
> it is okay for now and should be taken care in my next submission???

Please stop top posting and please stop removing the comments that you are
replying to.  Your message should be self contained.  The person looking
at only the message should understand the whole context of what you are
saying.

I think you are asking about the extra ---.  Don't worry about it.

julia

>
> Thank you.
> Deepak.
>
> On Tuesday, 10 March 2020 21:21:05 UTC+5:30, Deepak Varma wrote:
>       there are 2 #if 0 blocks that have no recent history of any
>       change. We
>       can remove those code blocks for improved readability of the
>       code.
>
>       Signed-off-by: Deepak R Varma <mh12gx2825@gmail.com>
>       ---
>        drivers/staging/comedi/drivers/dt2801.c | 22
>       ----------------------
>        1 file changed, 22 deletions(-)
>
>       diff --git a/drivers/staging/comedi/drivers/dt2801.c
>       b/drivers/staging/comedi/drivers/dt2801.c
>       index a29880981d81..aad02faa2f83 100644
>       --- a/drivers/staging/comedi/drivers/dt2801.c
>       +++ b/drivers/staging/comedi/drivers/dt2801.c
>       @@ -87,17 +87,6 @@
>        #define DT2801_STATUS                1
>        #define DT2801_CMD                1
>        
>       -#if 0
>       -/* ignore 'defined but not used' warning */
>       -static const struct comedi_lrange range_dt2801_ai_pgh_bipolar =
>       {
>       -        4, {
>       -                BIP_RANGE(10),
>       -                BIP_RANGE(5),
>       -                BIP_RANGE(2.5),
>       -                BIP_RANGE(1.25)
>       -        }
>       -};
>       -#endif
>        static const struct comedi_lrange range_dt2801_ai_pgl_bipolar =
>       {
>                4, {
>                        BIP_RANGE(10),
>       @@ -107,17 +96,6 @@ static const struct comedi_lrange
>       range_dt2801_ai_pgl_bipolar = {
>                }
>        };
>        
>       -#if 0
>       -/* ignore 'defined but not used' warning */
>       -static const struct comedi_lrange range_dt2801_ai_pgh_unipolar
>       = {
>       -        4, {
>       -                UNI_RANGE(10),
>       -                UNI_RANGE(5),
>       -                UNI_RANGE(2.5),
>       -                UNI_RANGE(1.25)
>       -        }
>       -};
>       -#endif
>        static const struct comedi_lrange range_dt2801_ai_pgl_unipolar
>       = {
>                4, {
>                        UNI_RANGE(10),
>       --
>       2.17.1
>
> --
> You received this message because you are subscribed to the Google Groups
> "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/b14f8972-f6c7-4ca6-8fe6-
> 55fc3517a186%40googlegroups.com.
>
>