Re: [Outreachy kernel] [PATCH] staging: rts5208: Fix long line in C func call argument

[Julia Lawall <julia.lawall@inria.fr>]

On Sat, 14 Mar 2020, R Veera Kumar wrote:

> A simple fix of long line in C function call argument.

Try to rewrite the whole thing without using the word "fix".  What did you
do and why?

Simple is not a good word to use, because it is your opinion.  It is
probably everyone's opinion in this case, but it is still an opinion.

julia


> Found using checkpatch.pl.
>
> Signed-off-by: R Veera Kumar <vkor@vkten.in>
> ---
>  drivers/staging/rts5208/rtsx_chip.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rts5208/rtsx_chip.c b/drivers/staging/rts5208/rtsx_chip.c
> index 17c4131f5f62..c6f9375468eb 100644
> --- a/drivers/staging/rts5208/rtsx_chip.c
> +++ b/drivers/staging/rts5208/rtsx_chip.c
> @@ -940,7 +940,8 @@ static void rtsx_monitor_aspm_config(struct rtsx_chip *chip)
>  		if (maybe_support_aspm)
>  			chip->aspm_l0s_l1_en = 0x03;
>
> -		dev_dbg(rtsx_dev(chip), "aspm_level[0] = 0x%02x, aspm_level[1] = 0x%02x\n",
> +		dev_dbg(rtsx_dev(chip),
> +			"aspm_level[0] = 0x%02x, aspm_level[1] = 0x%02x\n",
>  			chip->aspm_level[0], chip->aspm_level[1]);
>
>  		if (chip->aspm_l0s_l1_en) {
> --
> 2.20.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20200314060539.GA2709%40tulip.local.
>