From: Julia Lawall <julia.lawall@inria.fr>
To: John Wyatt <jbwyatt4@gmail.com>
Cc: "outreachy-kernel@googlegroups.com" <outreachy-kernel@googlegroups.com>
Subject: Re: [Outreachy kernel] [PATCH] staging: android: ion: Fix parenthesis alignment
Date: Thu, 2 Apr 2020 10:57:57 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.21.2004021056580.3130@hadrien> (raw)
In-Reply-To: <f8b3b9bb6544fb093b4c51b9626bfe8692e17b4c.camel@gmail.com>
On Thu, 2 Apr 2020, John Wyatt wrote:
> On Thu, 2020-04-02 at 09:11 +0200, Julia Lawall wrote:
> >
> > On Wed, 1 Apr 2020, John B. Wyatt IV wrote:
> >
> > > Fix 2 parenthesis alignment issues.
> >
> > Please try to find a way to describe what you have done that doesn't
> > involve the word "Fix". What have you done and why?
> >
>
> Understood.
>
> How about:
>
> Move spacing on function arguments to to comply with kernel style guide
> on parenthesis alignment.
It's better (but drop the second "to" :).
Obviously in this case it's not a big deal, but it's better to get out of
the habit of just saying "fix".
julia
next prev parent reply other threads:[~2020-04-02 8:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-02 1:25 [PATCH] staging: android: ion: Fix parenthesis alignment John B. Wyatt IV
2020-04-02 1:25 ` John B. Wyatt IV
2020-04-02 1:45 ` [Outreachy kernel] " Stefano Brivio
2020-04-02 1:45 ` Stefano Brivio
2020-04-02 7:11 ` Julia Lawall
2020-04-02 7:11 ` Julia Lawall
2020-04-02 8:54 ` John Wyatt
2020-04-02 8:57 ` Julia Lawall [this message]
2020-04-02 9:03 ` John Wyatt
2020-04-02 9:29 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.2004021056580.3130@hadrien \
--to=julia.lawall@inria.fr \
--cc=jbwyatt4@gmail.com \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.