From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julia Lawall Date: Fri, 08 May 2020 10:40:08 +0000 Subject: Re: [PATCH] powerpc/spufs: adjust list element pointer type Message-Id: List-Id: References: <1588929176-28527-1-git-send-email-Julia.Lawall@inria.fr> <4c9cc9184213ded65489cb95050046c8904ddad8.camel@ozlabs.org> In-Reply-To: <4c9cc9184213ded65489cb95050046c8904ddad8.camel@ozlabs.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Jeremy Kerr Cc: Nic Volanschi , Arnd Bergmann , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, Paul Mackerras , linuxppc-dev@lists.ozlabs.org On Fri, 8 May 2020, Jeremy Kerr wrote: > Hi Julia, > > > Other uses of &gang->aff_list_head, eg in spufs_assert_affinity, indicate > > that the list elements have type spu_context, not spu as used here. Change > > the type of tmp accordingly. > > Looks good to me; we could even use ctx there, rather than the separate > tmp variable. I thought about that, but it seemed a little bit abusive, since ctx is used in an iteration over another list. But if you prefer that I can change it. julia > > Reviewed-by: Jeremy Kerr > > Cheers, > > > Jeremy > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A56D7C38A2A for ; Fri, 8 May 2020 10:42:17 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E898520708 for ; Fri, 8 May 2020 10:42:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E898520708 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=inria.fr Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 49JRjM03BqzDr3r for ; Fri, 8 May 2020 20:42:15 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=inria.fr (client-ip=192.134.164.83; helo=mail2-relais-roc.national.inria.fr; envelope-from=julia.lawall@inria.fr; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=inria.fr Received: from mail2-relais-roc.national.inria.fr (mail2-relais-roc.national.inria.fr [192.134.164.83]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 49JRgK0djCzDqnZ for ; Fri, 8 May 2020 20:40:20 +1000 (AEST) X-IronPort-AV: E=Sophos;i="5.73,367,1583190000"; d="scan'208";a="448810012" Received: from abo-173-121-68.mrs.modulonet.fr (HELO hadrien) ([85.68.121.173]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 May 2020 12:40:08 +0200 Date: Fri, 8 May 2020 12:40:08 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Jeremy Kerr Subject: Re: [PATCH] powerpc/spufs: adjust list element pointer type In-Reply-To: <4c9cc9184213ded65489cb95050046c8904ddad8.camel@ozlabs.org> Message-ID: References: <1588929176-28527-1-git-send-email-Julia.Lawall@inria.fr> <4c9cc9184213ded65489cb95050046c8904ddad8.camel@ozlabs.org> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nic Volanschi , Arnd Bergmann , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, Paul Mackerras , linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Fri, 8 May 2020, Jeremy Kerr wrote: > Hi Julia, > > > Other uses of &gang->aff_list_head, eg in spufs_assert_affinity, indicate > > that the list elements have type spu_context, not spu as used here. Change > > the type of tmp accordingly. > > Looks good to me; we could even use ctx there, rather than the separate > tmp variable. I thought about that, but it seemed a little bit abusive, since ctx is used in an iteration over another list. But if you prefer that I can change it. julia > > Reviewed-by: Jeremy Kerr > > Cheers, > > > Jeremy > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1E60C38A2A for ; Fri, 8 May 2020 10:40:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A50AF20708 for ; Fri, 8 May 2020 10:40:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727032AbgEHKkS (ORCPT ); Fri, 8 May 2020 06:40:18 -0400 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:28123 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726519AbgEHKkS (ORCPT ); Fri, 8 May 2020 06:40:18 -0400 X-IronPort-AV: E=Sophos;i="5.73,367,1583190000"; d="scan'208";a="448810012" Received: from abo-173-121-68.mrs.modulonet.fr (HELO hadrien) ([85.68.121.173]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 May 2020 12:40:08 +0200 Date: Fri, 8 May 2020 12:40:08 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Jeremy Kerr cc: kernel-janitors@vger.kernel.org, Arnd Bergmann , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, Nic Volanschi Subject: Re: [PATCH] powerpc/spufs: adjust list element pointer type In-Reply-To: <4c9cc9184213ded65489cb95050046c8904ddad8.camel@ozlabs.org> Message-ID: References: <1588929176-28527-1-git-send-email-Julia.Lawall@inria.fr> <4c9cc9184213ded65489cb95050046c8904ddad8.camel@ozlabs.org> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 8 May 2020, Jeremy Kerr wrote: > Hi Julia, > > > Other uses of &gang->aff_list_head, eg in spufs_assert_affinity, indicate > > that the list elements have type spu_context, not spu as used here. Change > > the type of tmp accordingly. > > Looks good to me; we could even use ctx there, rather than the separate > tmp variable. I thought about that, but it seemed a little bit abusive, since ctx is used in an iteration over another list. But if you prefer that I can change it. julia > > Reviewed-by: Jeremy Kerr > > Cheers, > > > Jeremy > >