From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julia Lawall Date: Thu, 27 Aug 2020 20:05:10 +0000 Subject: Re: [PATCH] coccinelle: api: fix kobj_to_dev.cocci warnings Message-Id: MIME-Version: 1 Content-Type: multipart/mixed; boundary="8323329-1007646674-1598558711=:2482" List-Id: References: <13cd8bf4-06f9-04d7-e923-c397c506e8cc@web.de> In-Reply-To: <13cd8bf4-06f9-04d7-e923-c397c506e8cc@web.de> To: Markus Elfring Cc: linux-fbdev@vger.kernel.org, kbuild-all@lists.01.org, kernel test robot , Bartlomiej Zolnierkiewicz , kernel-janitors@vger.kernel.org, Bernie Thompson , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Denis Efremov This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-1007646674-1598558711=:2482 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit On Thu, 27 Aug 2020, Markus Elfring wrote: > > Generated by: scripts/coccinelle/api/kobj_to_dev.cocci > > > > Fixes: a2fc3718bc22 ("coccinelle: api: add kobj_to_dev.cocci script") > > I wonder about such a combination of information. > > I find it reasonable that two function implementations should be adjusted > according to a generated patch. > Thus I imagine that not the mentioned SmPL script is “fixed” > but the affected source file “drivers/video/fbdev/udlfb.c” may be improved. > Will the subject “[PATCH] video: udlfb: Fix kobj_to_dev.cocci warnings” > (or “[PATCH] video: udlfb: Use kobj_to_dev() instead of container_of()”) > be more appropriate for the proposed commit message? It seems that 0-day picks up new semantic patches that are added to trees in kernel.org, but that it's strategy for generating the patch is not ideal. I'll just drop these Fixes lines. julia --8323329-1007646674-1598558711=:2482-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5354C433E7 for ; Fri, 28 Aug 2020 07:30:15 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A2494208CA for ; Fri, 28 Aug 2020 07:30:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A2494208CA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=inria.fr Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3CB076EB81; Fri, 28 Aug 2020 07:29:19 +0000 (UTC) Received: from mail3-relais-sop.national.inria.fr (mail3-relais-sop.national.inria.fr [192.134.164.104]) by gabe.freedesktop.org (Postfix) with ESMTPS id 579916E2D3 for ; Thu, 27 Aug 2020 20:05:15 +0000 (UTC) X-IronPort-AV: E=Sophos;i="5.76,359,1592863200"; d="scan'208";a="357455363" Received: from abo-173-121-68.mrs.modulonet.fr (HELO hadrien) ([85.68.121.173]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Aug 2020 22:05:11 +0200 Date: Thu, 27 Aug 2020 22:05:10 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Markus Elfring Subject: Re: [PATCH] coccinelle: api: fix kobj_to_dev.cocci warnings In-Reply-To: <13cd8bf4-06f9-04d7-e923-c397c506e8cc@web.de> Message-ID: References: <13cd8bf4-06f9-04d7-e923-c397c506e8cc@web.de> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8323329-1007646674-1598558711=:2482" X-Mailman-Approved-At: Fri, 28 Aug 2020 07:29:10 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, kbuild-all@lists.01.org, kernel test robot , Bartlomiej Zolnierkiewicz , kernel-janitors@vger.kernel.org, Bernie Thompson , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Denis Efremov Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-1007646674-1598558711=:2482 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT On Thu, 27 Aug 2020, Markus Elfring wrote: > > Generated by: scripts/coccinelle/api/kobj_to_dev.cocci > > > > Fixes: a2fc3718bc22 ("coccinelle: api: add kobj_to_dev.cocci script") > > I wonder about such a combination of information. > > I find it reasonable that two function implementations should be adjusted > according to a generated patch. > Thus I imagine that not the mentioned SmPL script is “fixed” > but the affected source file “drivers/video/fbdev/udlfb.c” may be improved. > Will the subject “[PATCH] video: udlfb: Fix kobj_to_dev.cocci warnings” > (or “[PATCH] video: udlfb: Use kobj_to_dev() instead of container_of()”) > be more appropriate for the proposed commit message? It seems that 0-day picks up new semantic patches that are added to trees in kernel.org, but that it's strategy for generating the patch is not ideal. I'll just drop these Fixes lines. julia --8323329-1007646674-1598558711=:2482 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel --8323329-1007646674-1598558711=:2482-- From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============5085457863166100272==" MIME-Version: 1.0 From: Julia Lawall To: kbuild-all@lists.01.org Subject: Re: [PATCH] coccinelle: api: fix kobj_to_dev.cocci warnings Date: Thu, 27 Aug 2020 22:05:10 +0200 Message-ID: In-Reply-To: <13cd8bf4-06f9-04d7-e923-c397c506e8cc@web.de> List-Id: --===============5085457863166100272== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On Thu, 27 Aug 2020, Markus Elfring wrote: > > Generated by: scripts/coccinelle/api/kobj_to_dev.cocci > > > > Fixes: a2fc3718bc22 ("coccinelle: api: add kobj_to_dev.cocci script") > > I wonder about such a combination of information. > > I find it reasonable that two function implementations should be adjusted > according to a generated patch. > Thus I imagine that not the mentioned SmPL script is =E2=80=9Cfixed=E2=80= =9D > but the affected source file =E2=80=9Cdrivers/video/fbdev/udlfb.c=E2=80= =9D may be improved. > Will the subject =E2=80=9C[PATCH] video: udlfb: Fix kobj_to_dev.cocci war= nings=E2=80=9D > (or =E2=80=9C[PATCH] video: udlfb: Use kobj_to_dev() instead of container= _of()=E2=80=9D) > be more appropriate for the proposed commit message? It seems that 0-day picks up new semantic patches that are added to trees in kernel.org, but that it's strategy for generating the patch is not ideal. I'll just drop these Fixes lines. julia --===============5085457863166100272==-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65614C433E1 for ; Thu, 27 Aug 2020 20:05:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3C0EC2071B for ; Thu, 27 Aug 2020 20:05:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726952AbgH0UFO (ORCPT ); Thu, 27 Aug 2020 16:05:14 -0400 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:21081 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726120AbgH0UFO (ORCPT ); Thu, 27 Aug 2020 16:05:14 -0400 X-IronPort-AV: E=Sophos;i="5.76,359,1592863200"; d="scan'208";a="357455363" Received: from abo-173-121-68.mrs.modulonet.fr (HELO hadrien) ([85.68.121.173]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Aug 2020 22:05:11 +0200 Date: Thu, 27 Aug 2020 22:05:10 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Markus Elfring cc: Bartlomiej Zolnierkiewicz , Bernie Thompson , Denis Efremov , kernel test robot , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, kbuild-all@lists.01.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] coccinelle: api: fix kobj_to_dev.cocci warnings In-Reply-To: <13cd8bf4-06f9-04d7-e923-c397c506e8cc@web.de> Message-ID: References: <13cd8bf4-06f9-04d7-e923-c397c506e8cc@web.de> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8323329-1007646674-1598558711=:2482" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-1007646674-1598558711=:2482 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT On Thu, 27 Aug 2020, Markus Elfring wrote: > > Generated by: scripts/coccinelle/api/kobj_to_dev.cocci > > > > Fixes: a2fc3718bc22 ("coccinelle: api: add kobj_to_dev.cocci script") > > I wonder about such a combination of information. > > I find it reasonable that two function implementations should be adjusted > according to a generated patch. > Thus I imagine that not the mentioned SmPL script is “fixed” > but the affected source file “drivers/video/fbdev/udlfb.c” may be improved. > Will the subject “[PATCH] video: udlfb: Fix kobj_to_dev.cocci warnings” > (or “[PATCH] video: udlfb: Use kobj_to_dev() instead of container_of()”) > be more appropriate for the proposed commit message? It seems that 0-day picks up new semantic patches that are added to trees in kernel.org, but that it's strategy for generating the patch is not ideal. I'll just drop these Fixes lines. julia --8323329-1007646674-1598558711=:2482--