From: Julia Lawall <julia.lawall@inria.fr>
To: Kees Cook <keescook@chromium.org>
Cc: cocci@inria.fr, "Darrick J. Wong" <djwong@kernel.org>
Subject: Re: [cocci] coccinelle is skipping include files?
Date: Thu, 20 Oct 2022 06:43:35 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.22.394.2210200639050.2988@hadrien> (raw)
In-Reply-To: <202210191620.171E11C@keescook>
> The example I'm looking at is fs/xfs/xfs_bmap_item.c, which starts with:
> #include "xfs.h"
> #include "xfs_fs.h"
> #include "xfs_format.h"
> #include "xfs_log_format.h"
> ...
>
>
> Here it is working, if I explicitly as for "xfs_log_format.h" to be
> included:
>
> $ ARGS="--very-quiet \
> -I ./arch/x86/include \
> -I ./arch/x86/include/generated \
> -I ./include \
> -I ./arch/x86/include/uapi \
> -I ./arch/x86/include/generated/uapi \
> -I ./include/uapi \
> -I ./include/generated/uapi \
> --include ./include/linux/compiler-version.h \
> --include ./include/linux/kconfig.h \
> --jobs 36 --chunksize 1"
> $ spatch $ARGS --all-includes --cocci-file t.cocci \
> --include fs/xfs/libxfs/xfs_log_format.h \
> fs/xfs/xfs_bmap_item.c
> --- fs/xfs/xfs_bmap_item.c
> +++ /tmp/cocci-output-742963-d11c3c-xfs_bmap_item.c
> @@ -625,7 +625,6 @@ xfs_bui_copy_format(
> len = xfs_bui_log_format_sizeof(src_bui_fmt->bui_nextents);
>
> if (buf->i_len == len) {
> - memcpy(dst_bui_fmt, src_bui_fmt, len);
> return 0;
> }
> XFS_ERROR_REPORT(__func__, XFS_ERRLEVEL_LOW, NULL);
>
>
> But if I don't explicitly ask it to process
> "fs/xfs/libxfs/xfs_log_format.h", it doesn't match,
> no matter what "includes" option I try:
You may want to start with the option --verbose-includes for such
problems.
The problem is that Coccinelle can't find the file. Your .c file is in
fs/xfs, and despite the lack of a complete path, the header file is in
a subdirectory: fs/xfs/libxfs. So you could add -I fs/xfs/libxfs to your
command line.
Another solution is the option --relax-include-path. This should cause
Coccinelle to look over the entire kernel to see if it can find exactly
one file named xfs_log_format.h. If only one exists, that has to be the
one you want.
julia
>
> $ spatch $ARGS --all-includes --cocci-file t.cocci \
> fs/xfs/xfs_bmap_item.c
> $ spatch $ARGS -recusrive-includes --cocci-file t.cocci \
> fs/xfs/xfs_bmap_item.c
>
> Weirder yet, it doesn't seem to even _try_ to include the right headers.
>
> $ strace -f -e openat \
> spatch $ARGS --all-includes --cocci-file t.cocci \
> fs/xfs/xfs_bmap_item.c \
> 2>&1 | grep '\.h"' | grep xfs
> openat(AT_FDCWD, "fs/xfs/xfs.h", O_RDONLY|O_CLOEXEC) = 4
> openat(AT_FDCWD, "fs/xfs/xfs_mount.h", O_RDONLY|O_CLOEXEC) = 4
> openat(AT_FDCWD, "fs/xfs/xfs_inode.h", O_RDONLY|O_CLOEXEC) = 4
> openat(AT_FDCWD, "fs/xfs/xfs_trans.h", O_RDONLY|O_CLOEXEC) = 4
> openat(AT_FDCWD, "fs/xfs/xfs_trans_priv.h", O_RDONLY|O_CLOEXEC) = 4
> openat(AT_FDCWD, "fs/xfs/xfs_bmap_item.h", O_RDONLY|O_CLOEXEC) = 4
> openat(AT_FDCWD, "fs/xfs/xfs_log.h", O_RDONLY|O_CLOEXEC) = 4
> openat(AT_FDCWD, "fs/xfs/xfs_icache.h", O_RDONLY|O_CLOEXEC) = 4
> openat(AT_FDCWD, "fs/xfs/xfs_error.h", O_RDONLY|O_CLOEXEC) = 4
> openat(AT_FDCWD, "fs/xfs/xfs_log_priv.h", O_RDONLY|O_CLOEXEC) = 4
>
> Using --recursive-includes open a massive amount of headers, but still
> not fs/xfs/libxfs/xfs_log_format.h:
>
> $ strace -f -e openat \
> spatch $ARGS --recursive-includes --cocci-file t.cocci \
> fs/xfs/xfs_bmap_item.c \
> 2>&1 | grep '\.h"' | grep xfs
> openat(AT_FDCWD, "fs/xfs/xfs.h", O_RDONLY|O_CLOEXEC) = 4
> openat(AT_FDCWD, "fs/xfs/xfs_linux.h", O_RDONLY|O_CLOEXEC) = 4
> openat(AT_FDCWD, "fs/xfs/kmem.h", O_RDONLY|O_CLOEXEC) = 4
> openat(AT_FDCWD, "./include/uapi/linux/dqblk_xfs.h", O_RDONLY|O_CLOEXEC) = 4
> openat(AT_FDCWD, "fs/xfs/mrlock.h", O_RDONLY|O_CLOEXEC) = 4
> openat(AT_FDCWD, "fs/xfs/xfs_stats.h", O_RDONLY|O_CLOEXEC) = 4
> openat(AT_FDCWD, "fs/xfs/xfs_sysctl.h", O_RDONLY|O_CLOEXEC) = 4
> openat(AT_FDCWD, "fs/xfs/xfs_iops.h", O_RDONLY|O_CLOEXEC) = 4
> openat(AT_FDCWD, "fs/xfs/xfs_aops.h", O_RDONLY|O_CLOEXEC) = 4
> openat(AT_FDCWD, "fs/xfs/xfs_super.h", O_RDONLY|O_CLOEXEC) = 4
> openat(AT_FDCWD, "fs/xfs/xfs_buf.h", O_RDONLY|O_CLOEXEC) = 4
> openat(AT_FDCWD, "fs/xfs/xfs_message.h", O_RDONLY|O_CLOEXEC) = 4
> openat(AT_FDCWD, "fs/xfs/xfs_mount.h", O_RDONLY|O_CLOEXEC) = 4
> openat(AT_FDCWD, "fs/xfs/xfs_inode.h", O_RDONLY|O_CLOEXEC) = 4
> openat(AT_FDCWD, "fs/xfs/xfs_trans.h", O_RDONLY|O_CLOEXEC) = 4
> openat(AT_FDCWD, "fs/xfs/xfs_trans_priv.h", O_RDONLY|O_CLOEXEC) = 4
> openat(AT_FDCWD, "fs/xfs/xfs_bmap_item.h", O_RDONLY|O_CLOEXEC) = 4
> openat(AT_FDCWD, "fs/xfs/xfs_log.h", O_RDONLY|O_CLOEXEC) = 4
> openat(AT_FDCWD, "fs/xfs/xfs_icache.h", O_RDONLY|O_CLOEXEC) = 4
> openat(AT_FDCWD, "fs/xfs/xfs_error.h", O_RDONLY|O_CLOEXEC) = 4
> openat(AT_FDCWD, "fs/xfs/xfs_log_priv.h", O_RDONLY|O_CLOEXEC) = 4
> openat(AT_FDCWD, "fs/xfs/xfs_message.h", O_RDONLY|O_CLOEXEC) = 4
>
> Any idea what is going on here?
>
> Thanks!
>
> -Kees
>
> --
> Kees Cook
>
next prev parent reply other threads:[~2022-10-20 4:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-19 23:36 [cocci] coccinelle is skipping include files? Kees Cook
2022-10-20 4:43 ` Julia Lawall [this message]
2022-10-20 5:18 ` Kees Cook
2022-10-20 5:23 ` Julia Lawall
2022-10-24 16:53 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.22.394.2210200639050.2988@hadrien \
--to=julia.lawall@inria.fr \
--cc=cocci@inria.fr \
--cc=djwong@kernel.org \
--cc=keescook@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.