All of lore.kernel.org
 help / color / mirror / Atom feed
From: Julia Lawall <julia.lawall@inria.fr>
To: Deepak R Varma <drv@mailo.com>
Cc: outreachy@lists.linux.dev
Subject: Re: Coccinelle based patch processing
Date: Tue, 1 Nov 2022 15:34:52 +0100 (CET)	[thread overview]
Message-ID: <alpine.DEB.2.22.394.2211011532430.2834@hadrien> (raw)
In-Reply-To: <Y2Epr3nxdZs/Cc6+@ubunlion>



On Tue, 1 Nov 2022, Deepak R Varma wrote:

> Hello,
> I have a coccicheck produced patch [attached here] using the following command.
> Can you please suggest how to submit this as a patch? Is there a document that I
> can follow to accomplish the submission?
>
>    make coccicheck COCCI=./scripts/coccinelle/misc/returnvar.cocci M=driver/staging/r8188eu/ MODE=patch

Do what you would have done if you had made the patch by hand.

If the changes are quite identical, then you can group changes on multiple
files into one.

But in this case, even though all the changes do the same thing, it may
not be a good idea to group them, because the context is different in each
case.  In particular, you should check each case to see whether the return
variable really was unnecessary, or whether it actually was necessary, and
the developer forgot to set it to something.

julia


>
> Thank you,
> ./drv
>

  reply	other threads:[~2022-11-01 14:34 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-01 14:14 Coccinelle based patch processing Deepak R Varma
2022-11-01 14:34 ` Julia Lawall [this message]
2022-11-01 14:52   ` Deepak R Varma
2022-11-01 15:09     ` Julia Lawall
2022-11-01 15:19       ` Deepak R Varma
2022-11-01 15:28         ` Julia Lawall
2022-11-01 16:57           ` Deepak R Varma

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.22.394.2211011532430.2834@hadrien \
    --to=julia.lawall@inria.fr \
    --cc=drv@mailo.com \
    --cc=outreachy@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.