From: Julia Lawall <julia.lawall@inria.fr>
To: Kloudifold <cloudifold.3125@gmail.com>
Cc: alison.schofield@intel.com, outreachy@lists.linux.dev
Subject: Re: Problem in "Pick a warning, and try to fix it": Don't have a warning to pick
Date: Thu, 9 Mar 2023 07:29:39 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.22.394.2303090726250.3294@hadrien> (raw)
In-Reply-To: <ZAkE4w/T389R2+Er@CloudiRingWorld>
On Thu, 9 Mar 2023, Kloudifold wrote:
> Hello, I am Kloudifold, an Outreachy applicant.
>
> I'm reading https://kernelnewbies.org/Outreachyfirstpatch and trying to make my first patch. It says, "Pick a warning, and try to fix it. For your first patch, only pick one warning.", but when I used the command:
>
> > perl scripts/checkpatch.pl -f drivers/staging/*/* | grep "[1-9] warnings" -B 10 -A 2
>
> I can only find warnings for drivers/staging/axis-fifo/axis-fifo.c, a file that is already being submitted to the mailing list, which means I don't have a warning to pick.
> How should I finish my first patch in this case? Should I look for something more difficult than changing the coding style?
I'm surprised that there would only be one warning in all of staging. But
who knows.
Your grep may be missing cases with eg 10 warnings?
Maybe see if some of the CHECK or ERROR cases are easy to do?
If you find nothing at all, a few days ago I posted a list of cases where
the argument indentation might be undesirable. You cold look hrough them
for something that could be improved.
julia
prev parent reply other threads:[~2023-03-09 6:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-08 21:57 Problem in "Pick a warning, and try to fix it": Don't have a warning to pick Kloudifold
2023-03-08 23:59 ` Alison Schofield
2023-03-09 6:29 ` Julia Lawall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.22.394.2303090726250.3294@hadrien \
--to=julia.lawall@inria.fr \
--cc=alison.schofield@intel.com \
--cc=cloudifold.3125@gmail.com \
--cc=outreachy@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.