From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail2-relais-roc.national.inria.fr (mail2-relais-roc.national.inria.fr [192.134.164.83]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AFF8BC02198 for ; Sat, 8 Feb 2025 11:58:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inria.fr; s=dc; h=date:from:to:cc:in-reply-to:message-id:references: mime-version:subject:reply-to:sender:list-id:list-help: list-subscribe:list-unsubscribe:list-post:list-owner: list-archive; bh=dMBWVKeCtJNKScR/CHhadsRNErfmAwYDq4+N44AZKRY=; b=XzgPFgN6A5c/racKrMw+eqKQb9g6u+t/o1U9MQbH39B+x/qPBFGsYTnt tTFoybieBnP0NWfnT3YO/cnZLh+o1SnEaKE93WKp+45yuO7zmpKW5wZrv EKpzog8jQkqYM40hiL3O69anIG1gVdbRId3hlZWxaVlo9qmR2l+1l1Npv Q=; Received-SPF: Pass (mail2-relais-roc.national.inria.fr: domain of cocci-owner@inria.fr designates 128.93.162.160 as permitted sender) identity=mailfrom; client-ip=128.93.162.160; receiver=mail2-relais-roc.national.inria.fr; envelope-from="cocci-owner@inria.fr"; x-sender="cocci-owner@inria.fr"; x-conformance=spf_only; x-record-type="v=spf1"; x-record-text="v=spf1 include:mailout.safebrands.com a:basic-mail.safebrands.com a:basic-mail01.safebrands.com a:basic-mail02.safebrands.com ip4:128.93.142.0/24 ip4:192.134.164.0/24 ip4:128.93.162.160 ip4:128.93.162.3 ip4:128.93.162.88 ip4:89.107.174.7 mx ~all" Received-SPF: None (mail2-relais-roc.national.inria.fr: no sender authenticity information available from domain of postmaster@sympa.inria.fr) identity=helo; client-ip=128.93.162.160; receiver=mail2-relais-roc.national.inria.fr; envelope-from="cocci-owner@inria.fr"; x-sender="postmaster@sympa.inria.fr"; x-conformance=spf_only Authentication-Results: mail2-relais-roc.national.inria.fr; spf=Pass smtp.mailfrom=cocci-owner@inria.fr; spf=None smtp.helo=postmaster@sympa.inria.fr; dkim=pass (signature verified) header.i=@inria.fr X-IronPort-AV: E=Sophos;i="6.13,269,1732575600"; d="scan'208";a="207284132" Received: from prod-listesu18.inria.fr (HELO sympa.inria.fr) ([128.93.162.160]) by mail2-relais-roc.national.inria.fr with ESMTP; 08 Feb 2025 12:58:06 +0100 Received: by sympa.inria.fr (Postfix, from userid 20132) id 110DCE0D1E; Sat, 8 Feb 2025 12:58:06 +0100 (CET) Received: from mail2-relais-roc.national.inria.fr (mail2-relais-roc.national.inria.fr [192.134.164.83]) by sympa.inria.fr (Postfix) with ESMTPS id 149DFE0260 for ; Sat, 8 Feb 2025 12:58:03 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inria.fr; s=dc; h=date:from:to:cc:subject:in-reply-to:message-id: references:mime-version; bh=dMBWVKeCtJNKScR/CHhadsRNErfmAwYDq4+N44AZKRY=; b=HE5HpwDfPDKN15Kg6xspp1+gla0ELjq0uwwOrD4G1JvwD4iqaN7Va6hW wP4k0gq203maas3hLTGvwupEpcN2+8Am7p5a59AY1iT1r5HICUXXA4LTY xQ+pvlECu3Qc/3ays06XvE0l/xffuxdx74L3UOZKafGVbk4x8BZQWJTJP k=; X-IronPort-AV: E=Sophos;i="6.13,269,1732575600"; d="scan'208";a="207284131" Received: from 231.85.89.92.rev.sfr.net (HELO hadrien) ([92.89.85.231]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Feb 2025 12:58:03 +0100 Date: Sat, 8 Feb 2025 12:58:02 +0100 (CET) From: Julia Lawall X-X-Sender: jll@hadrien To: Markus Elfring cc: cocci@inria.fr, Johannes Berg In-Reply-To: <6bbdaca7-2fa0-4bdf-bdc7-ba76a5a1d171@web.de> Message-ID: References: <381b5a9cb89cc068ca13546f69636291874010b3.camel@sipsolutions.net> <061f1b6b50d305671c02742382a3df0ff95f9c6b.camel@sipsolutions.net> <9063a6e6c83f9169456bc009cc35426889cc46e1.camel@sipsolutions.net> <6bbdaca7-2fa0-4bdf-bdc7-ba76a5a1d171@web.de> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8323329-129827194-1739015883=:15422" Subject: Re: [cocci] Checking SmPL test cases? Reply-To: Julia Lawall X-Loop: cocci@inria.fr X-Sequence: 2372 Errors-To: cocci-owner@inria.fr Precedence: list Precedence: bulk Sender: cocci-request@inria.fr X-no-archive: yes List-Id: List-Help: List-Subscribe: List-Unsubscribe: List-Post: List-Owner: List-Archive: Archived-At: This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-129827194-1739015883=:15422 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT On Sat, 8 Feb 2025, Markus Elfring wrote: > > That seems ... simple enough? > Can you get further development ideas from test data like the following? > > SmPL script example: > @deletion@ > identifier i; > @@ > static inline int > i(...) > { > ... > -if (rnr_elems) {...} > ... > } > > > Test result: > Markus_Elfring@Sonne:…/Projekte/Coccinelle/Probe> time spatch delete_statement3-Johannes_Berg.cocci test-beacon_len-20250206.c > … > diff = > warning: deletion, node 19: statement[1,2,4,5,7,8] in my_beacon_len may be inconsistently modified > warning: deletion, node 16: [fortrue][1,2,4,5,7] in my_beacon_len may be inconsistently modified > warning: deletion, node 15: for[1,2,4,5,7]* in my_beacon_len may be inconsistently modified > … > @@ -7,12 +7,5 @@ my_beacon_len(struct cfg80211_mbssid_ele > { > int len = 0; > > - if (rnr_elems) { > - u8 i; > - > - for (i = 0; i < rnr_elems->cnt; i++) > - len += rnr_elems->elem[i].len; > - } > - > return len; > } > > real 0m0,058s > user 0m0,041s > sys 0m0,016s > > > Another source file example: > static inline int > my_beacon_len(struct cfg80211_mbssid_elems *elems, > struct cfg80211_rnr_elems *rnr_elems, > u8 i) > { > int len = 0; > > if (i < elems->cnt) { > len = elems->elem[i].len; > if (rnr_elems) { > len += rnr_elems->elem[i].len; > for (i = elems->cnt; i < rnr_elems->cnt; i++) > len += rnr_elems->elem[i].len; > } > return len; > } > > return len; > } > > > Questionable test result: > Markus_Elfring@Sonne:…/Projekte/Coccinelle/Probe> time spatch delete_statement3-Johannes_Berg.cocci test2-beacon_len-20250206.c > … > real 0m1,653s > user 0m1,635s > sys 0m0,017s > > > May I expect the generation of corresponding difference output here? No. The matched if doesn't occur on every control-flow path. julia --8323329-129827194-1739015883=:15422--