From: Linus Torvalds <torvalds@linux-foundation.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: Robert Shearman <robertshearman@gmail.com>,
git@vger.kernel.org, Robert Shearman <rob@codeweavers.com>
Subject: Re: [PATCH 2/4] git-imap-send: Add support for SSL.
Date: Wed, 9 Jul 2008 18:31:02 -0700 (PDT) [thread overview]
Message-ID: <alpine.LFD.1.10.0807091825500.11076@woody.linux-foundation.org> (raw)
In-Reply-To: <7v8wwa5ycf.fsf@gitster.siamese.dyndns.org>
On Wed, 9 Jul 2008, Junio C Hamano wrote:
>
> A hack like the one attached below would make it "work" but it is too
> ugly. Probably we need to bite the bullet and rename ours not to
> collide, so that external library headers can safely include <ctype.h>.
We should be able to safely include <ctype.h> as-is.
It should just happen _before_ including git-compat-util.h. That's why
git-compat-util.h does all those #undef's - exactly because ctype.h does
get included on various systems by various header files when
git-compat-util.h includes all those other files.
So the problem with Robert's patch is that it happens after "cache.h". The
system headers should be included at the top of git-compat-util.h, or
before it.
Linus
next prev parent reply other threads:[~2008-07-10 1:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-09 21:29 [PATCH 2/4] git-imap-send: Add support for SSL Robert Shearman
2008-07-10 1:20 ` Junio C Hamano
2008-07-10 1:31 ` Linus Torvalds [this message]
2008-07-10 2:02 ` Junio C Hamano
2008-07-10 5:33 ` Mike Hommey
-- strict thread matches above, loose matches on Subject: below --
2008-07-08 22:18 Robert Shearman
2008-07-08 23:20 ` Junio C Hamano
2008-07-09 2:28 ` Abhijit Menon-Sen
2008-07-09 12:02 ` Rob Shearman
2008-07-09 18:28 ` Junio C Hamano
2008-07-09 15:14 ` Josh Triplett
2008-07-09 21:24 ` Rob Shearman
2008-07-10 6:39 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.1.10.0807091825500.11076@woody.linux-foundation.org \
--to=torvalds@linux-foundation.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=rob@codeweavers.com \
--cc=robertshearman@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.