From: "Robert P. J. Day" <rpjday@crashcourse.ca>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: Andrew Morton <akpm@osdl.org>, ysato@users.sourceforge.jp
Subject: Re: [PATCH] H8/300: Correct Kconfig "select"s by dropping CONFIG_ prefix.
Date: Sat, 13 Jun 2009 11:01:34 -0400 (EDT) [thread overview]
Message-ID: <alpine.LFD.2.00.0906131059570.20669@localhost> (raw)
In-Reply-To: <alpine.LFD.2.00.0906131053270.19255@localhost>
whoops, ignore, there's another problem in this Kconfig file...
On Sat, 13 Jun 2009, Robert P. J. Day wrote:
> Kconfig "select" directives shouldn't use a "CONFIG_" prefix.
>
> Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
>
> ---
>
> diff --git a/arch/h8300/Kconfig.cpu b/arch/h8300/Kconfig.cpu
> index b65dcfe..038637a 100644
> --- a/arch/h8300/Kconfig.cpu
> +++ b/arch/h8300/Kconfig.cpu
> @@ -13,7 +13,7 @@ config H8300H_GENERIC
>
> config H8300H_AKI3068NET
> bool "AE-3068/69"
> - select CONFIG_H83068
> + select H83068
> help
> AKI-H8/3068F / AKI-H8/3069F Flashmicom LAN Board Support
> More Information. (Japanese Only)
> @@ -24,7 +24,7 @@ config H8300H_AKI3068NET
>
> config H8300H_H8MAX
> bool "H8MAX"
> - select CONFIG_H83068
> + select H83068
> help
> H8MAX Evaluation Board Support
> More Information. (Japanese Only)
> @@ -32,7 +32,7 @@ config H8300H_H8MAX
>
> config H8300H_SIM
> bool "H8/300H Simulator"
> - select CONFIG_H83007
> + select H83007
> help
> GDB Simulator Support
> More Information.
> @@ -45,7 +45,7 @@ config H8S_GENERIC
>
> config H8S_EDOSK2674
> bool "EDOSK-2674"
> - select CONFIG_H8S2768
> + select H8S2768
that's a separate typo, should actually be "H8S2678", to match the
later "config" directive. ignore this. sorry.
rday
--
========================================================================
Robert P. J. Day Waterloo, Ontario, CANADA
Linux Consulting, Training and Annoying Kernel Pedantry.
Web page: http://crashcourse.ca
Linked In: http://www.linkedin.com/in/rpjday
Twitter: http://twitter.com/rpjday
========================================================================
prev parent reply other threads:[~2009-06-13 15:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-13 14:55 [PATCH] H8/300: Correct Kconfig "select"s by dropping CONFIG_ prefix Robert P. J. Day
2009-06-13 15:01 ` Robert P. J. Day [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.0906131059570.20669@localhost \
--to=rpjday@crashcourse.ca \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.