All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Robert P. J. Day" <rpjday@crashcourse.ca>
To: linux-fsdevel@vger.kernel.org
Subject: for seq_file.c, EXPORT seq_path_root() and seq_dentry()?
Date: Mon, 10 Aug 2009 10:24:45 -0400 (EDT)	[thread overview]
Message-ID: <alpine.LFD.2.00.0908101019001.2929@localhost> (raw)


  in the process of writing a newbie article on how to use the
seq_file implementation of proc files, and i noticed that, in
fs/seq_file.c, mangle_path() is EXPORTed, as is seq_path(), but
neither of seq_path_root() or seq_dentry().

  that just seems slightly inconsistent.  is there any value (or
obvious drawback) to EXPORTing those other two?

rday

p.s.  LDD3 writes of seq_path():

"It is unlikely to be used in device drivers: we have included it here
for completeness."

it is invoked exactly once in the source tree, in drivers/md/md.c.
just an observation.


--

========================================================================
Robert P. J. Day                               Waterloo, Ontario, CANADA

        Linux Consulting, Training and Annoying Kernel Pedantry.

Web page:                                          http://crashcourse.ca
Twitter:                                       http://twitter.com/rpjday
========================================================================

                 reply	other threads:[~2009-08-10 14:27 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.00.0908101019001.2929@localhost \
    --to=rpjday@crashcourse.ca \
    --cc=linux-fsdevel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.