From: Robert P. J. Day <rpjday@crashcourse.ca>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Move the preprocessor test for building flash.c to the Makefile.
Date: Thu, 19 Nov 2009 13:03:04 -0500 (EST) [thread overview]
Message-ID: <alpine.LFD.2.00.0911191302350.14465@localhost> (raw)
In-Reply-To: <200911191303.58750.vapier@gentoo.org>
On Thu, 19 Nov 2009, Mike Frysinger wrote:
> On Thursday 19 November 2009 12:38:42 Robert P. J. Day wrote:
> > --- a/common/Makefile
> > +++ b/common/Makefile
> > @@ -152,7 +152,9 @@ COBJS-$(CONFIG_VFD) += cmd_vfd.o
> > COBJS-$(CONFIG_DDR_SPD) += ddr_spd.o
> > COBJS-$(CONFIG_HWCONFIG) += hwconfig.o
> > COBJS-$(CONFIG_CONSOLE_MUX) += iomux.o
> > +#ifndef CONFIG_SYS_NO_FLASH
> > COBJS-y += flash.o
> > +#endif
> > COBJS-$(CONFIG_CMD_KGDB) += kgdb.o
> > COBJS-$(CONFIG_KALLSYMS) += kallsyms.o
> > COBJS-$(CONFIG_LCD) += lcd.o
>
> me thinks you did not test this and/or you dont know how Makefile's work
> and/or you forgot to remove debug comments.
>
> regardless, obvious NACK
> -mike
oh, crap, that's what i get for getting lazy and not paying
attention. sorry.
rday
--
========================================================================
Robert P. J. Day Waterloo, Ontario, CANADA
Linux Consulting, Training and Kernel Pedantry.
Web page: http://crashcourse.ca
Twitter: http://twitter.com/rpjday
========================================================================
prev parent reply other threads:[~2009-11-19 18:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-19 17:38 [U-Boot] [PATCH] Move the preprocessor test for building flash.c to the Makefile Robert P. J. Day
2009-11-19 18:03 ` Mike Frysinger
2009-11-19 18:03 ` Robert P. J. Day [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.0911191302350.14465@localhost \
--to=rpjday@crashcourse.ca \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.