* [U-Boot] [PATCH] BeagleBoard: Add a comment explaining the use of "OMAP34XX" macros.
@ 2009-11-20 2:03 Robert P. J. Day
2009-11-20 2:13 ` Måns Rullgård
0 siblings, 1 reply; 6+ messages in thread
From: Robert P. J. Day @ 2009-11-20 2:03 UTC (permalink / raw)
To: u-boot
Make it clear to a reader that the user of OMAP34XX macros in the
(OMAP 3530-based) beagle config file is just fine.
Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
---
i'll let dirk be the judge as to whether this is worth adding, or if
he'd prefer a different phrasing.
diff --git a/include/configs/omap3_beagle.h b/include/configs/omap3_beagle.h
index 19a5ec9..9a03587 100644
--- a/include/configs/omap3_beagle.h
+++ b/include/configs/omap3_beagle.h
@@ -30,6 +30,9 @@
/*
* High Level Configuration Options
+ *
+ * Note that, although the BeagleBoard incorporates an OMAP 3530,
+ * it's currently still valid to use OMAP34XX preprocessor values.
*/
#define CONFIG_ARMCORTEXA8 1 /* This is an ARM V7 CPU core */
#define CONFIG_OMAP 1 /* in a TI OMAP core */
========================================================================
Robert P. J. Day Waterloo, Ontario, CANADA
Linux Consulting, Training and Kernel Pedantry.
Web page: http://crashcourse.ca
Twitter: http://twitter.com/rpjday
========================================================================
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] BeagleBoard: Add a comment explaining the use of "OMAP34XX" macros.
2009-11-20 2:03 [U-Boot] [PATCH] BeagleBoard: Add a comment explaining the use of "OMAP34XX" macros Robert P. J. Day
@ 2009-11-20 2:13 ` Måns Rullgård
2009-11-20 2:21 ` Nishanth Menon
2009-11-20 2:29 ` Robert P. J. Day
0 siblings, 2 replies; 6+ messages in thread
From: Måns Rullgård @ 2009-11-20 2:13 UTC (permalink / raw)
To: u-boot
"Robert P. J. Day" <rpjday@crashcourse.ca> writes:
> Make it clear to a reader that the user of OMAP34XX macros in the
> (OMAP 3530-based) beagle config file is just fine.
>
> Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
>
> ---
>
> i'll let dirk be the judge as to whether this is worth adding, or if
> he'd prefer a different phrasing.
>
> diff --git a/include/configs/omap3_beagle.h b/include/configs/omap3_beagle.h
> index 19a5ec9..9a03587 100644
> --- a/include/configs/omap3_beagle.h
> +++ b/include/configs/omap3_beagle.h
> @@ -30,6 +30,9 @@
>
> /*
> * High Level Configuration Options
> + *
> + * Note that, although the BeagleBoard incorporates an OMAP 3530,
> + * it's currently still valid to use OMAP34XX preprocessor values.
> */
> #define CONFIG_ARMCORTEXA8 1 /* This is an ARM V7 CPU core */
> #define CONFIG_OMAP 1 /* in a TI OMAP core */
Since 34xx and 35xx are in fact exactly the same silicon, saying it is
"currently" valid seems a bit odd. This sort of implies a planned
change.
--
M?ns Rullg?rd
mans at mansr.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] BeagleBoard: Add a comment explaining the use of "OMAP34XX" macros.
2009-11-20 2:13 ` Måns Rullgård
@ 2009-11-20 2:21 ` Nishanth Menon
2009-11-20 2:36 ` Robert P. J. Day
2009-11-20 2:29 ` Robert P. J. Day
1 sibling, 1 reply; 6+ messages in thread
From: Nishanth Menon @ 2009-11-20 2:21 UTC (permalink / raw)
To: u-boot
2009/11/19 M?ns Rullg?rd <mans@mansr.com>:
> "Robert P. J. Day" <rpjday@crashcourse.ca> writes:
>
>> Make it clear to a reader that the user of OMAP34XX macros in the
>> (OMAP 3530-based) beagle config file is just fine.
>>
>> Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
>>
>> ---
>>
>> ? i'll let dirk be the judge as to whether this is worth adding, or if
>> he'd prefer a different phrasing.
>>
>> diff --git a/include/configs/omap3_beagle.h b/include/configs/omap3_beagle.h
>> index 19a5ec9..9a03587 100644
>> --- a/include/configs/omap3_beagle.h
>> +++ b/include/configs/omap3_beagle.h
>> @@ -30,6 +30,9 @@
>>
>> ?/*
>> ? * High Level Configuration Options
>> + *
>> + * Note that, although the BeagleBoard incorporates an OMAP 3530,
>> + * it's currently still valid to use OMAP34XX preprocessor values.
>> ? */
>> ?#define CONFIG_ARMCORTEXA8 ? 1 ? ? ? /* This is an ARM V7 CPU core */
>> ?#define CONFIG_OMAP ? ? ? ? ?1 ? ? ? /* in a TI OMAP core */
>
> Since 34xx and 35xx are in fact exactly the same silicon, saying it is
> "currently" valid seems a bit odd. ?This sort of implies a planned
> change.
>
I agree - I do not think there are any such plans. NAK to the patch.
Regards,
Nishanth Menon
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] BeagleBoard: Add a comment explaining the use of "OMAP34XX" macros.
2009-11-20 2:13 ` Måns Rullgård
2009-11-20 2:21 ` Nishanth Menon
@ 2009-11-20 2:29 ` Robert P. J. Day
1 sibling, 0 replies; 6+ messages in thread
From: Robert P. J. Day @ 2009-11-20 2:29 UTC (permalink / raw)
To: u-boot
On Fri, 20 Nov 2009, M?ns Rullg?rd wrote:
> "Robert P. J. Day" <rpjday@crashcourse.ca> writes:
>
> > Make it clear to a reader that the user of OMAP34XX macros in the
> > (OMAP 3530-based) beagle config file is just fine.
> >
> > Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
> >
> > ---
> >
> > i'll let dirk be the judge as to whether this is worth adding, or if
> > he'd prefer a different phrasing.
> >
> > diff --git a/include/configs/omap3_beagle.h b/include/configs/omap3_beagle.h
> > index 19a5ec9..9a03587 100644
> > --- a/include/configs/omap3_beagle.h
> > +++ b/include/configs/omap3_beagle.h
> > @@ -30,6 +30,9 @@
> >
> > /*
> > * High Level Configuration Options
> > + *
> > + * Note that, although the BeagleBoard incorporates an OMAP 3530,
> > + * it's currently still valid to use OMAP34XX preprocessor values.
> > */
> > #define CONFIG_ARMCORTEXA8 1 /* This is an ARM V7 CPU core */
> > #define CONFIG_OMAP 1 /* in a TI OMAP core */
>
> Since 34xx and 35xx are in fact exactly the same silicon, saying it is
> "currently" valid seems a bit odd. This sort of implies a planned
> change.
ok, i can rephrase that. i was working off of a post by dirk a
couple days ago where he seemed to be suggesting that the door was
open for some divergence down the road, but maybe i just misread.
will fix shortly.
rday
--
========================================================================
Robert P. J. Day Waterloo, Ontario, CANADA
Linux Consulting, Training and Kernel Pedantry.
Web page: http://crashcourse.ca
Twitter: http://twitter.com/rpjday
========================================================================
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] BeagleBoard: Add a comment explaining the use of "OMAP34XX" macros.
2009-11-20 2:21 ` Nishanth Menon
@ 2009-11-20 2:36 ` Robert P. J. Day
2009-11-20 10:31 ` Måns Rullgård
0 siblings, 1 reply; 6+ messages in thread
From: Robert P. J. Day @ 2009-11-20 2:36 UTC (permalink / raw)
To: u-boot
On Thu, 19 Nov 2009, Nishanth Menon wrote:
> I agree - I do not think there are any such plans. NAK to the patch.
> Regards,
> Nishanth Menon
fair enough. but i think a two-line comment is still useful for
people new to ARM who know the beagle is a 3530 and wonder why all the
macros use 34XX.
rday
--
========================================================================
Robert P. J. Day Waterloo, Ontario, CANADA
Linux Consulting, Training and Kernel Pedantry.
Web page: http://crashcourse.ca
Twitter: http://twitter.com/rpjday
========================================================================
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] BeagleBoard: Add a comment explaining the use of "OMAP34XX" macros.
2009-11-20 2:36 ` Robert P. J. Day
@ 2009-11-20 10:31 ` Måns Rullgård
0 siblings, 0 replies; 6+ messages in thread
From: Måns Rullgård @ 2009-11-20 10:31 UTC (permalink / raw)
To: u-boot
"Robert P. J. Day" <rpjday@crashcourse.ca> writes:
> On Thu, 19 Nov 2009, Nishanth Menon wrote:
>
>> I agree - I do not think there are any such plans. NAK to the patch.
>> Regards,
>> Nishanth Menon
>
> fair enough. but i think a two-line comment is still useful for
> people new to ARM who know the beagle is a 3530 and wonder why all the
> macros use 34XX.
Not disagreeing about the comment as such, only about the wording.
--
M?ns Rullg?rd
mans at mansr.com
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2009-11-20 10:31 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-11-20 2:03 [U-Boot] [PATCH] BeagleBoard: Add a comment explaining the use of "OMAP34XX" macros Robert P. J. Day
2009-11-20 2:13 ` Måns Rullgård
2009-11-20 2:21 ` Nishanth Menon
2009-11-20 2:36 ` Robert P. J. Day
2009-11-20 10:31 ` Måns Rullgård
2009-11-20 2:29 ` Robert P. J. Day
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.