From: Linus Torvalds <torvalds@linux-foundation.org>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Jesse Barnes <jbarnes@virtuousgeek.org>,
Eric Anholt <eric@anholt.net>,
Zhenyu Wang <zhenyuw@linux.intel.com>,
LKML <linux-kernel@vger.kernel.org>,
pm list <linux-pm@lists.linux-foundation.org>,
dri-devel@lists.sourceforge.net
Subject: Re: [PATCH] DRM / i915: Fix resume regression on MSI Wind U100 w/o KMS
Date: Fri, 8 Jan 2010 16:50:57 -0800 (PST) [thread overview]
Message-ID: <alpine.LFD.2.00.1001081648490.7821@localhost.localdomain> (raw)
In-Reply-To: <201001090146.17793.rjw@sisk.pl>
On Sat, 9 Jan 2010, Rafael J. Wysocki wrote:
>
> Which is functionally equivalent to my patch, because i915_suspend/resume()
> won't be called by drm_class_suspend/resume() in the KMS case anyway.
Ahh, right you are - that class suspend function does a check for
DRIVER_MODESET, and only does the suspend/resume if it's not a MODESET
driver.
Ok, so I withdraw my objections to your original patch - it's confusing,
but that's just because DRM is such a horrible mess with subtle things.
Linus
next prev parent reply other threads:[~2010-01-09 0:51 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-08 23:45 [PATCH] DRM / i915: Fix resume regression on MSI Wind U100 w/o KMS Rafael J. Wysocki
2010-01-08 23:45 ` Rafael J. Wysocki
2010-01-09 0:01 ` Linus Torvalds
2010-01-09 0:01 ` Linus Torvalds
2010-01-09 0:06 ` Jesse Barnes
2010-01-09 0:21 ` Jesse Barnes
2010-01-09 0:21 ` Jesse Barnes
2010-01-09 0:21 ` Jesse Barnes
2010-01-09 0:43 ` Rafael J. Wysocki
2010-01-09 0:43 ` Rafael J. Wysocki
2010-01-09 0:06 ` Jesse Barnes
2010-01-09 0:21 ` Rafael J. Wysocki
2010-01-09 0:21 ` Rafael J. Wysocki
2010-01-09 0:32 ` Jesse Barnes
2010-01-09 0:46 ` Rafael J. Wysocki
2010-01-09 0:50 ` Linus Torvalds [this message]
2010-01-09 1:13 ` Jesse Barnes
2010-01-09 13:35 ` [PATCH] i915: Always register as a PCI driver (was: Re: [PATCH] DRM / i915: Fix resume regression on MSI Wind U100 w/o KMS) Rafael J. Wysocki
2010-01-09 21:41 ` Dave Airlie
2010-01-09 21:41 ` Dave Airlie
2010-01-09 21:41 ` Dave Airlie
2010-01-09 22:07 ` Rafael J. Wysocki
2010-01-09 22:07 ` Rafael J. Wysocki
2010-01-09 13:35 ` Rafael J. Wysocki
2010-01-09 1:13 ` [PATCH] DRM / i915: Fix resume regression on MSI Wind U100 w/o KMS Jesse Barnes
2010-01-09 0:50 ` Linus Torvalds
2010-01-09 0:46 ` Rafael J. Wysocki
2010-01-09 0:32 ` Jesse Barnes
2010-01-09 2:15 ` Dave Airlie
2010-01-09 2:50 ` Jesse Barnes
2010-01-09 2:50 ` Jesse Barnes
2010-01-09 12:01 ` Jerome Glisse
2010-01-09 18:17 ` Linus Torvalds
2010-01-09 18:17 ` Linus Torvalds
2010-01-09 21:32 ` Dave Airlie
2010-01-09 21:32 ` Dave Airlie
2010-01-09 21:32 ` Dave Airlie
2010-01-11 16:38 ` Jesse Barnes
2010-01-11 20:12 ` Dave Airlie
2010-01-11 20:12 ` Dave Airlie
2010-01-11 20:22 ` Jesse Barnes
2010-01-11 20:22 ` Jesse Barnes
2010-01-11 21:04 ` Rafael J. Wysocki
2010-01-11 21:43 ` Julien Cristau
2010-01-11 22:22 ` Rafael J. Wysocki
2010-01-11 22:22 ` Rafael J. Wysocki
2010-01-11 23:05 ` Dave Airlie
2010-01-11 23:05 ` Dave Airlie
2010-01-11 23:16 ` Rafael J. Wysocki
2010-01-11 23:16 ` Rafael J. Wysocki
2010-01-11 23:05 ` Dave Airlie
2010-01-11 21:43 ` Julien Cristau
2010-01-11 21:04 ` Rafael J. Wysocki
2010-01-11 20:12 ` Dave Airlie
2010-01-11 16:38 ` Jesse Barnes
2010-01-09 12:01 ` Jerome Glisse
2010-01-09 2:15 ` Dave Airlie
2010-01-12 22:33 ` Eric Anholt
2010-01-12 22:48 ` Rafael J. Wysocki
2010-01-12 22:48 ` Rafael J. Wysocki
2010-01-12 22:33 ` Eric Anholt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.1001081648490.7821@localhost.localdomain \
--to=torvalds@linux-foundation.org \
--cc=dri-devel@lists.sourceforge.net \
--cc=eric@anholt.net \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=rjw@sisk.pl \
--cc=zhenyuw@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.