From: Linus Torvalds <torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
To: akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org
Cc: kosaki.motohiro-+CUm20s59erQFUHtdCDX3A@public.gmane.org,
bdonlan-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
drepper-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org,
linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
mingo-X9Un+BFzKDI@public.gmane.org,
oleg-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
tss-X3B1VOXEql0@public.gmane.org,
xiyou.wangcong-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
Subject: Re: [patch 050/160] prctl: add PR_SET_PROCTITLE_AREA option for prctl()
Date: Sat, 6 Mar 2010 11:05:31 -0800 (PST) [thread overview]
Message-ID: <alpine.LFD.2.00.1003061100170.4530@localhost.localdomain> (raw)
In-Reply-To: <201003052142.o25Lgbpg029522-AB4EexQrvXRQetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>
On Fri, 5 Mar 2010, akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org wrote:
>
> This patch makes it possible for userspace to implement setproctitle()
> cleanly. It adds a new PR_SET_PROCTITLE_AREA option for prctl(), which
> updates task's mm_struct->arg_start and arg_end to the given area.
This looks overly complicated. Why do you change the whole locking rules,
instead of protecting _only_ the "arg_start/arg_end" case?
The thing is, there's no reason to hold the mmap_sem over the whole thing,
and I don't think this is important enough to be a valid reason for
exposing a whole new "locked" access variant, when a simple "protect just
the arg_start/end" would handle it.
Linus
next prev parent reply other threads:[~2010-03-06 19:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-05 21:42 [patch 050/160] prctl: add PR_SET_PROCTITLE_AREA option for prctl() akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b
[not found] ` <201003052142.o25Lgbpg029522-AB4EexQrvXRQetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>
2010-03-06 19:05 ` Linus Torvalds [this message]
[not found] ` <alpine.LFD.2.00.1003061100170.4530-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2010-03-07 19:28 ` Oleg Nesterov
[not found] ` <20100307192826.GA18616-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2010-03-07 20:24 ` Bryan Donlan
[not found] ` <3e8340491003071224o5ea1c01cl73132e7c2cc6046f-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-03-08 12:56 ` Oleg Nesterov
2010-03-09 5:14 ` KOSAKI Motohiro
[not found] ` <20100306095705.GA26221@infradead.org>
[not found] ` <20100306095705.GA26221-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2010-03-09 4:44 ` KOSAKI Motohiro
[not found] ` <20100309134105.7CDB.A69D9226-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2010-03-09 5:21 ` Ulrich Drepper
[not found] ` <4B95DAF3.5050605-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2010-03-09 22:17 ` Oleg Nesterov
[not found] ` <20100309221704.GA1401-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2010-03-09 22:33 ` Ulrich Drepper
[not found] ` <4B96CCB8.9040507-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2010-03-10 1:42 ` KOSAKI Motohiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.1003061100170.4530@localhost.localdomain \
--to=torvalds-de/tnxtf+jlsfhdxvbkv3wd2fqjk+8+b@public.gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=bdonlan-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=drepper-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org \
--cc=kosaki.motohiro-+CUm20s59erQFUHtdCDX3A@public.gmane.org \
--cc=linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mingo-X9Un+BFzKDI@public.gmane.org \
--cc=oleg-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=tss-X3B1VOXEql0@public.gmane.org \
--cc=xiyou.wangcong-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.