All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Robert P. J. Day" <rpjday@crashcourse.ca>
To: linux-mm@kvack.org
Subject: [PATCH] MM: Make "struct vm_region {...}" depend on !CONFIG_MMU.
Date: Mon, 5 Apr 2010 10:56:30 -0400 (EDT)	[thread overview]
Message-ID: <alpine.LFD.2.00.1004051052410.8295@localhost> (raw)


Since the "vm_region" structure appears to be relevant only under
NOMMU, conditionally include it in mm_types.h.

Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>

---

  if i read mm_types.h, i can see the obvious conditional inclusion:

#ifndef CONFIG_MMU
        struct vm_region *vm_region;    /* NOMMU mapping region */
#endif

since that's the case, it seems only consistent to make the structure
declaration itself similarly conditional, no?

diff --git a/include/linux/mm_types.h b/include/linux/mm_types.h
index b8bb9a6..76f1174 100644
--- a/include/linux/mm_types.h
+++ b/include/linux/mm_types.h
@@ -102,6 +102,7 @@ struct page {
 #endif
 };

+#ifndef CONFIG_MMU
 /*
  * A region containing a mapping of a non-memory backed file under NOMMU
  * conditions.  These are held in a global tree and are pinned by the VMAs that
@@ -120,6 +121,7 @@ struct vm_region {
 	bool		vm_icache_flushed : 1; /* true if the icache has been flushed for
 						* this region */
 };
+#endif

 /*
  * This struct defines a memory VMM memory area. There is one of these


========================================================================
Robert P. J. Day                               Waterloo, Ontario, CANADA

            Linux Consulting, Training and Kernel Pedantry.

Web page:                                          http://crashcourse.ca
Twitter:                                       http://twitter.com/rpjday
========================================================================

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

                 reply	other threads:[~2010-04-05 14:58 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.00.1004051052410.8295@localhost \
    --to=rpjday@crashcourse.ca \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.