All of lore.kernel.org
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Matthew Garrett <mjg@redhat.com>
Cc: linux-input@vger.kernel.org, dmitry.torokhov@gmail.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2 3/3] input: Default to only using PNP for i8042 probing on x86
Date: Mon, 17 May 2010 13:52:39 -0700 (PDT)	[thread overview]
Message-ID: <alpine.LFD.2.00.1005171352010.4195@i5.linux-foundation.org> (raw)
In-Reply-To: <1274110716-12488-3-git-send-email-mjg@redhat.com>



On Mon, 17 May 2010, Matthew Garrett wrote:
> @@ -744,9 +746,10 @@ static int __init i8042_pnp_init(void)
>  
>  	if (!i8042_pnp_kbd_devices && !i8042_pnp_aux_devices) {
>  		i8042_pnp_exit();
> -#if defined(__ia64__)
> -		return -ENODEV;
> -#else
> +
> +		if (!acpi_disabled)
> +			return -ENODEV;
> +
>  		printk(KERN_INFO "PNP: No PS/2 controller found. Probing ports directly.\n");
>  		return 0;
>  #endif

This can't be right. That #endif is still there. How could this even 
compile?

Tssk, tssk.

		Linus

  reply	other threads:[~2010-05-17 20:55 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-17 15:38 [PATCH V2 1/3] input: Add some extra PNP keyboard types Matthew Garrett
2010-05-17 15:38 ` [PATCH V2 2/3] input: Add a PNP entry to the aux device list Matthew Garrett
2010-05-17 15:38 ` [PATCH V2 3/3] input: Default to only using PNP for i8042 probing on x86 Matthew Garrett
2010-05-17 20:52   ` Linus Torvalds [this message]
2010-05-17 21:02     ` Matthew Garrett
2010-05-17 21:19     ` [PATCH V3] " Matthew Garrett

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.00.1005171352010.4195@i5.linux-foundation.org \
    --to=torvalds@linux-foundation.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mjg@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.