From: Len Brown <lenb@kernel.org>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
Linux-pm mailing list <linux-pm@lists.linux-foundation.org>,
Matthew Garrett <mjg59@srcf.ucam.org>
Subject: Re: [Resend][PATCH 0/3] ACPI / PM: Patches missing from linux-acpi-2.6/test
Date: Mon, 13 Dec 2010 15:31:19 -0500 (EST) [thread overview]
Message-ID: <alpine.LFD.2.00.1012131523320.16730@x980> (raw)
In-Reply-To: <201012112339.53105.rjw@sisk.pl>
> Hi Len,
>
> The following three patches seem to have been dropped from your 'test' branch.
>
> If that happened by accident, please reapply. Otherwise, please let me know
> what's wrong with the patches so that I can fix them.
>
> [1/3] - Make fujitsu_laptop use acpi_bus_update_power() instead of
> acpi_bus_get_power() which is unsafe.
>
> [2/3] - Drop acpi_bus_get_power() which is unsafe and has no users.
>
> [3/3] - Do not call __acpi_bus_get_power() from acpi_bus_set_power()
> and remove acpi_power_nocheck that is not necessary any more.
>
> Without these patches the power resources handling rework is incomplete and
> the code will not work correctly in some situations.
Looks like my screw-up.
I recall inserting the fujitsu patch to fix the
build before what were originally 12/13 and 13/13 of this series,
but apparently I kept the baseline branch and deleted the fix on top of it.
Yes, in general, I do squawk when I drop patches from acpi-test,
even if it is a temporary drop due to a time-consuming manual merge.
So thanks for noticing, I'll look at these again now.
Len Brown
Intel Open Source Technology Center
next prev parent reply other threads:[~2010-12-13 20:31 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-11 22:39 [Resend][PATCH 0/3] ACPI / PM: Patches missing from linux-acpi-2.6/test Rafael J. Wysocki
2010-12-11 22:43 ` [Resend][PATCH 1/3] Platform / x86: Make fujitsu_laptop use acpi_bus_update_power() Rafael J. Wysocki
2010-12-11 22:43 ` Rafael J. Wysocki
2011-01-01 2:34 ` Jonathan Woithe
2011-01-01 2:34 ` Jonathan Woithe
2010-12-11 22:44 ` [Resend][PATCH 2/3] ACPI / PM: Drop acpi_bus_get_power() Rafael J. Wysocki
2010-12-11 22:44 ` Rafael J. Wysocki
2010-12-11 22:45 ` [Resend][PATCH 3/3] ACPI / PM: Drop acpi_power_nocheck Rafael J. Wysocki
2010-12-11 22:45 ` Rafael J. Wysocki
2010-12-13 8:35 ` [Resend][PATCH 0/3] ACPI / PM: Patches missing from linux-acpi-2.6/test ykzhao
2010-12-13 21:25 ` Rafael J. Wysocki
2010-12-13 21:25 ` Rafael J. Wysocki
2010-12-14 1:21 ` ykzhao
2010-12-14 1:21 ` ykzhao
2010-12-14 20:24 ` Rafael J. Wysocki
2010-12-15 2:17 ` ykzhao
2010-12-15 22:20 ` Rafael J. Wysocki
2010-12-15 22:20 ` Rafael J. Wysocki
2010-12-15 2:17 ` ykzhao
2010-12-14 20:24 ` Rafael J. Wysocki
2010-12-13 8:35 ` ykzhao
2010-12-13 20:31 ` Len Brown [this message]
2010-12-13 21:11 ` Rafael J. Wysocki
2010-12-13 21:11 ` Rafael J. Wysocki
2010-12-13 20:31 ` Len Brown
-- strict thread matches above, loose matches on Subject: below --
2010-12-11 22:39 Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.1012131523320.16730@x980 \
--to=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=mjg59@srcf.ucam.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.