Re: [PATCH] ext4: Reserve FEATURE_RO_COMPAT and INO flag

["Lukáš Czerner" <lczerner@redhat.com>]

On Fri, 26 Apr 2013, Andreas Dilger wrote:

> Date: Fri, 26 Apr 2013 05:47:58 -0600
> From: Andreas Dilger <adilger@dilger.ca>
> To: Lukas Czerner <lczerner@redhat.com>
> Cc: "linux-ext4@vger.kernel.org" <linux-ext4@vger.kernel.org>,
>     Lukas Czerner <lczerner@redhat.com>
> Subject: Re: [PATCH] ext4: Reserve FEATURE_RO_COMPAT and INO flag
> 
> I was looking in the maint and master branches, but I don't see these flags anywhere?

That's odd. I am using git repository:

git://git.kernel.org/pub/scm/fs/ext2/e2fsprogs.git

and it is there added with the commit
991211f676f49c6cf30af368dade2f81287f1fa8 libext2fs, libe2p: Reserve
RO_COMPAT_REPLICA feature

-Lukas

> 
> Cheers, Andreas
> 
> On 2013-04-25, at 8:39, Lukas Czerner <lczerner@redhat.com> wrote:
> 
> > EXT4_FEATURE_RO_COMPAT_REPLICA and EXT4_REPLICA_INO are reserved in
> > e2fsprogs for non-upstream feature. However it has never been reserved
> > in kernel, fix this. Thanks to Radek Pazdera to pointing it out.
> > 
> > Signed-off-by: Lukas Czerner <lczerner@redhat.com>
> > ---
> > fs/ext4/ext4.h |    3 +++
> > 1 files changed, 3 insertions(+), 0 deletions(-)
> > 
> > diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h
> > index 3b83cd6..6369c28 100644
> > --- a/fs/ext4/ext4.h
> > +++ b/fs/ext4/ext4.h
> > @@ -241,6 +241,7 @@ struct ext4_io_submit {
> > #define EXT4_UNDEL_DIR_INO     6    /* Undelete directory inode */
> > #define EXT4_RESIZE_INO         7    /* Reserved group descriptors inode */
> > #define EXT4_JOURNAL_INO     8    /* Journal inode */
> > +#define EXT4_REPLICA_INO     10    /* Used by non-upstream feature */
> > 
> > /* First non-reserved inode for old ext4 filesystems */
> > #define EXT4_GOOD_OLD_FIRST_INO    11
> > @@ -1481,6 +1482,8 @@ static inline void ext4_clear_state_flags(struct ext4_inode_info *ei)
> >  * GDT_CSUM bits are mutually exclusive.
> >  */
> > #define EXT4_FEATURE_RO_COMPAT_METADATA_CSUM    0x0400
> > +/* Reserved for non-upstream feature */
> > +#define EXT4_FEATURE_RO_COMPAT_REPLICA        0x0800
> > 
> > #define EXT4_FEATURE_INCOMPAT_COMPRESSION    0x0001
> > #define EXT4_FEATURE_INCOMPAT_FILETYPE        0x0002
> > -- 
> > 1.7.7.6
> > 
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
>