From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756888AbZFLPR3 (ORCPT ); Fri, 12 Jun 2009 11:17:29 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754532AbZFLPRS (ORCPT ); Fri, 12 Jun 2009 11:17:18 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:39539 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756460AbZFLPRR (ORCPT ); Fri, 12 Jun 2009 11:17:17 -0400 Date: Fri, 12 Jun 2009 08:16:41 -0700 (PDT) From: Linus Torvalds X-X-Sender: torvalds@localhost.localdomain To: Pekka J Enberg cc: Nick Piggin , Ingo Molnar , linux-mm@kvack.org, linux-kernel@vger.kernel.org, benh@kernel.crashing.org, akpm@linux-foundation.org, cl@linux-foundation.org Subject: Re: [PATCH v2] slab,slub: ignore __GFP_WAIT if we're booting or suspending In-Reply-To: Message-ID: References: <20090612091002.GA32052@elte.hu> <84144f020906120249y20c32d47y5615a32b3c9950df@mail.gmail.com> <20090612100756.GA25185@elte.hu> <84144f020906120311x7c7dd628s82e3ca9a840f9890@mail.gmail.com> <20090612101511.GC13607@wotan.suse.de> User-Agent: Alpine 2.01 (LFD 1184 2008-12-16) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 12 Jun 2009, Pekka J Enberg wrote: > > Hmm. This is turning into one epic patch discussion for sure! But here's a > patch to do what you suggested. With the amount of patches I am > generating, I'm bound to hit the right one sooner or later, no?-) Ok, this one looks pretty good. I like the statics, and I like how it lets each allocator decide what to do. Small nit: your mm/slab.c patch does an obviously unnecessary mask in: cache_alloc_debugcheck_before(cachep, flags & slab_gfp_flags); but that's stupid, because the bits were already masked earlier. Linus From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail191.messagelabs.com (mail191.messagelabs.com [216.82.242.19]) by kanga.kvack.org (Postfix) with ESMTP id B8EDE6B0082 for ; Fri, 12 Jun 2009 11:16:44 -0400 (EDT) Date: Fri, 12 Jun 2009 08:16:41 -0700 (PDT) From: Linus Torvalds Subject: Re: [PATCH v2] slab,slub: ignore __GFP_WAIT if we're booting or suspending In-Reply-To: Message-ID: References: <20090612091002.GA32052@elte.hu> <84144f020906120249y20c32d47y5615a32b3c9950df@mail.gmail.com> <20090612100756.GA25185@elte.hu> <84144f020906120311x7c7dd628s82e3ca9a840f9890@mail.gmail.com> <20090612101511.GC13607@wotan.suse.de> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org To: Pekka J Enberg Cc: Nick Piggin , Ingo Molnar , linux-mm@kvack.org, linux-kernel@vger.kernel.org, benh@kernel.crashing.org, akpm@linux-foundation.org, cl@linux-foundation.org List-ID: On Fri, 12 Jun 2009, Pekka J Enberg wrote: > > Hmm. This is turning into one epic patch discussion for sure! But here's a > patch to do what you suggested. With the amount of patches I am > generating, I'm bound to hit the right one sooner or later, no?-) Ok, this one looks pretty good. I like the statics, and I like how it lets each allocator decide what to do. Small nit: your mm/slab.c patch does an obviously unnecessary mask in: cache_alloc_debugcheck_before(cachep, flags & slab_gfp_flags); but that's stupid, because the bits were already masked earlier. Linus -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org