From: Linus Torvalds <torvalds@linux-foundation.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Joerg Roedel <joerg.roedel@amd.com>
Subject: Re: [PATCH] dma-debug: Fix the overlap() function to be correct and readable
Date: Fri, 10 Jul 2009 13:07:52 -0700 (PDT) [thread overview]
Message-ID: <alpine.LFD.2.01.0907101306000.3352@localhost.localdomain> (raw)
In-Reply-To: <20090710195157.GA31361@elte.hu>
On Fri, 10 Jul 2009, Ingo Molnar wrote:
>
> How about the patch below? Lightly tested.
>
> if (!PageHighMem(page)) {
> - void *addr = ((char *)page_address(page)) + offset;
> + void *addr = (void *)page_address(page) + offset;
> +
Why is that 'void *' cast there? page_address() is already a void *.
Other than that it obviously looks good to me. But I never see my own
bugs.
Linus
next prev parent reply other threads:[~2009-07-10 20:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-10 16:28 [GIT PULL] core kernel fixes Ingo Molnar
2009-07-10 19:06 ` Linus Torvalds
2009-07-10 19:31 ` Ingo Molnar
2009-07-10 19:51 ` [PATCH] dma-debug: Fix the overlap() function to be correct and readable Ingo Molnar
2009-07-10 20:07 ` Linus Torvalds [this message]
2009-07-10 20:34 ` Ingo Molnar
2009-07-14 10:15 ` Jaswinder Singh Rajput
2009-07-14 10:37 ` Jaswinder Singh Rajput
2009-07-14 10:52 ` Jaswinder Singh Rajput
2009-07-10 19:52 ` [GIT PULL] core kernel fixes Linus Torvalds
2009-07-10 20:02 ` Ingo Molnar
2009-07-10 20:36 ` [GIT PULL, v2] " Ingo Molnar
2009-07-13 14:52 ` [GIT PULL] " Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.01.0907101306000.3352@localhost.localdomain \
--to=torvalds@linux-foundation.org \
--cc=a.p.zijlstra@chello.nl \
--cc=joerg.roedel@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.