From: Thomas Gleixner <tglx@linutronix.de>
To: Ralf Baechle <ralf@linux-mips.org>
Cc: Pengfei Zhang <zoppof.zhang@gmail.com>,
linux-mips@linux-mips.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] MIPS:i8259.c remove resume and shutdown to syscore_ops
Date: Tue, 24 May 2011 16:01:43 +0200 (CEST) [thread overview]
Message-ID: <alpine.LFD.2.02.1105241600180.3078@ionos> (raw)
In-Reply-To: <20110524135940.GA30117@linux-mips.org>
On Tue, 24 May 2011, Ralf Baechle wrote:
> On Tue, May 24, 2011 at 08:19:18PM +0800, Pengfei Zhang wrote:
>
> > Remove the resume and shutdown of i8259A from the sysdev_class
> > to the syscore_ops since these members had removed from the
> > structure sysdev_class.
>
> I don't see why one would want to want to first call register_syscore_ops
> then sysdev_class_register and sysdev_register?
The whole point of syscore_ops is to get rid of the sysdev which had
only one purpose: handing the suspend/resume ops in. The resulting
sysfs entry is completely useless.
Thanks,
tglx
next prev parent reply other threads:[~2011-05-24 14:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-24 12:19 [PATCH] MIPS:i8259.c remove resume and shutdown to syscore_ops Pengfei Zhang
2011-05-24 13:59 ` Ralf Baechle
2011-05-24 14:01 ` Thomas Gleixner [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-05-24 14:25 Wanlong Gao
2011-05-24 18:59 ` Rafael J. Wysocki
2011-05-24 18:59 ` Rafael J. Wysocki
2011-05-24 19:09 ` Manuel Lauss
2011-05-24 19:09 ` Manuel Lauss
2011-05-24 23:14 ` Wanlong Gao
2011-05-24 23:14 ` Wanlong Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.02.1105241600180.3078@ionos \
--to=tglx@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
--cc=zoppof.zhang@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.