All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Jain Priyanka-B32167 <B32167@freescale.com>,
	"linux-rt-users@vger.kernel.org" <linux-rt-users@vger.kernel.org>,
	Srivastava Rajan-B34330 <B34330@freescale.com>
Subject: RE: [PATCH][UPSTREAM]net,RT:Remove preemption disabling in netif_rx()
Date: Sat, 26 May 2012 00:31:20 +0200 (CEST)	[thread overview]
Message-ID: <alpine.LFD.2.02.1205260028480.3231@ionos> (raw)
In-Reply-To: <1337865466.13348.175.camel@gandalf.stny.rr.com>

On Thu, 24 May 2012, Steven Rostedt wrote:

> On Thu, 2012-05-24 at 04:28 +0000, Jain Priyanka-B32167 wrote:
> > Waiting for review comments on this.
> > 
> 
> > diff --git a/net/core/dev.c b/net/core/dev.c index 452db70..4017820 100644
> > --- a/net/core/dev.c
> > +++ b/net/core/dev.c
> > @@ -2940,7 +2940,7 @@ int netif_rx(struct sk_buff *skb)
> >  		struct rps_dev_flow voidflow, *rflow = &voidflow;
> >  		int cpu;
> >  
> > -		preempt_disable();
> > +		migrate_disable();
> 
> I really want to avoid placing open coded migrate_disable() around the
> kernel. Perhaps we should use "get_cpu_light()" here too.

No. get_cpu_light() and migrate_disable() are different.

Following your argument we would have to replace preempt_disable()
with get_cpu() all over the place.

Thanks,

	tglx

  reply	other threads:[~2012-05-25 22:31 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-17  4:05 [PATCH][UPSTREAM]net,RT:Remove preemption disabling in netif_rx() Priyanka Jain
2012-05-24  4:28 ` Jain Priyanka-B32167
2012-05-24 13:17   ` Steven Rostedt
2012-05-25 22:31     ` Thomas Gleixner [this message]
2012-05-25 22:43       ` Steven Rostedt
2012-05-29  7:59         ` Peter Zijlstra
2012-06-05  9:04           ` Jain Priyanka-B32167

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.02.1205260028480.3231@ionos \
    --to=tglx@linutronix.de \
    --cc=B32167@freescale.com \
    --cc=B34330@freescale.com \
    --cc=linux-rt-users@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.