From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753212Ab2GPLP4 (ORCPT ); Mon, 16 Jul 2012 07:15:56 -0400 Received: from www.linutronix.de ([62.245.132.108]:52776 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752505Ab2GPLPw (ORCPT ); Mon, 16 Jul 2012 07:15:52 -0400 Date: Mon, 16 Jul 2012 13:15:47 +0200 (CEST) From: Thomas Gleixner To: "Rafael J. Wysocki" cc: Linus Torvalds , Linux PM list , LKML , John Stultz , Ingo Molnar , Peter Zijlstra , Prarit Bhargava , stable@vger.kernel.org, Andreas Schwab Subject: Re: [Regression][Revert request] Excessive delay or hang during resume from system suspend due to a hrtimer commit In-Reply-To: <201207161316.28875.rjw@sisk.pl> Message-ID: References: <201207152240.50129.rjw@sisk.pl> <201207161316.28875.rjw@sisk.pl> User-Agent: Alpine 2.02 (LFD 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 16 Jul 2012, Rafael J. Wysocki wrote: > On Monday, July 16, 2012, Thomas Gleixner wrote: > > On Sun, 15 Jul 2012, Rafael J. Wysocki wrote: > > > To everyone involved: the fact that this change, which was likely to introduce > > > regressions from the look of it alone, has been pushed to Linus (an to -stable > > > at the same time!) so late in the cycle, is seriuosly disappointing. > > > > Well, we spent an massive amount of time in testing, reviewing and > > discussion and it definitely did not break suspend/resume here. > > I'm not saying that you didn't consider it thoroughly, but unfortunately you > did overlook this particular issue, didn't you? > > > This was not pushed without a lot of thoughts and in fact what you are > > seing is another long standing bug in the timekeeping resume code, > > which was just papered over by the incorrect handling of the clock was > > set cases in the other parts of the system. > > > > Does the following patch fix the problem for you ? > > Yes, it does, thanks! > > > @John: Should that clear ntp as well or is it enough to set ntp_error > > to 0 ? > > > > /me really goes on vacation now. > > So who's going to take care of the patch? :-) I'm still packing gear. So i'll push it into timers/urgent.