Re: [net-next v3 06/16] i40e: Implementation of vxlan ndo's

[Joseph Gasparakis <joseph.gasparakis@intel.com>]

On Fri, 20 Dec 2013, David Miller wrote:

> From: Joseph Gasparakis <joseph.gasparakis@intel.com>
> Date: Fri, 20 Dec 2013 15:25:44 -0800 (PST)
> 
> > Right now the code in vxlan.h is:
> > 
> > #if IS_ENABLED(CONFIG_VXLAN)
> > void vxlan_get_rx_port(struct net_device *netdev);
> > #else
> > static inline void vxlan_get_rx_port(struct net_device *netdev)
> > {
> > }
> > #endif
> > 
> > so the function can be called from drivers whether vxlan is enabled in 
> > .config or not. However, the "depends on VXLAN || !VXLAN" is needed when 
> > the driver is compiled as a built-in, otherwise we get an undefined 
> > reference for the above function. If this is not the right way to fix the 
> > dependency please let me know and I will fix it accordingly.
> 
> Ok, can you write this with the more canonical:
> 
> 	(X || X=n)
> 
> That's how we write it out to handle the same issue with
> IPV6.
> 
> Thanks.

Will do. Thanks.

> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>